From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24555: [PATCH] Remove unused variable `command-debug-status' Date: Sat, 01 Oct 2016 20:39:39 +0300 Message-ID: <83bmz4klyc.fsf@gnu.org> References: <837f9woyu6.fsf@gnu.org> <83twczokd3.fsf@gnu.org> <83fuoioigw.fsf@gnu.org> <83k2dskqzq.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1475343621 30942 195.159.176.226 (1 Oct 2016 17:40:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 1 Oct 2016 17:40:21 +0000 (UTC) Cc: monnier@iro.umontreal.ca, 24555@debbugs.gnu.org To: Philippe Vaucher Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 01 19:40:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqOGl-00077Y-6r for geb-bug-gnu-emacs@m.gmane.org; Sat, 01 Oct 2016 19:40:15 +0200 Original-Received: from localhost ([::1]:56669 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqOGj-0005R0-MS for geb-bug-gnu-emacs@m.gmane.org; Sat, 01 Oct 2016 13:40:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqOGa-0005Qe-0s for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2016 13:40:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bqOGY-0005I4-2f for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2016 13:40:02 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35130) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqOGX-0005Hz-Vq for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2016 13:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bqOGX-0000W8-QG for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2016 13:40:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Oct 2016 17:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24555 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24555-submit@debbugs.gnu.org id=B24555.14753435991976 (code B ref 24555); Sat, 01 Oct 2016 17:40:01 +0000 Original-Received: (at 24555) by debbugs.gnu.org; 1 Oct 2016 17:39:59 +0000 Original-Received: from localhost ([127.0.0.1]:41320 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqOGU-0000Vn-Pa for submit@debbugs.gnu.org; Sat, 01 Oct 2016 13:39:59 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqOGS-0000VY-F6 for 24555@debbugs.gnu.org; Sat, 01 Oct 2016 13:39:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bqOGJ-0005CT-Vj for 24555@debbugs.gnu.org; Sat, 01 Oct 2016 13:39:51 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37082) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqOGJ-0005C2-Sq; Sat, 01 Oct 2016 13:39:47 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2282 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bqOGF-0007x1-Ub; Sat, 01 Oct 2016 13:39:46 -0400 In-reply-to: (message from Philippe Vaucher on Sat, 1 Oct 2016 18:12:06 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:123866 Archived-At: > From: Philippe Vaucher > Date: Sat, 1 Oct 2016 18:12:06 +0200 > Cc: Stefan Monnier , 24555@debbugs.gnu.org > > > I think your patch lacks the call to make-obsolete-variable. We need > > that to warn users of this variable about it being obsoleted. > > Well, I thought about it but was not sure about various things, so I didn't do it. Here are the things I'm unsure > about: > > (make-obsolete-variable OBSOLETE-NAME CURRENT-NAME WHEN &optional ACCESS-TYPE) > > Make the byte-compiler warn that OBSOLETE-NAME is obsolete. > The warning will say that CURRENT-NAME should be used instead. > If CURRENT-NAME is a string, that is the ‘use instead’ message. > WHEN should be a string indicating when the variable > was first made obsolete, for example a date or a release number. > > 1 Where should I make the `make-obsolete-variable` call (in which file)? Given it's defined in callint.c it's not > really obvious in which .el it should go. I'd say in subr.el; there's a bunch of those there already. > 2 I don't have a "current name". Should I make CURRENT-NAME something like "This variable will be > removed in the future"? Should I pass "nil"? The former, but I think the string should start with a lower-case letter, as it will be displayed after the standard text saying the variable is obsolete. I suggest to experiment with different strings and find the one which makes the most sense. > 3 What WHEN release number should I use? 25.2 ? Yes, 25.2. Thanks.