all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] ash, lsh: Avoid code duplication
Date: Mon, 21 Nov 2016 19:14:50 +0200	[thread overview]
Message-ID: <83bmx892lx.fsf@gnu.org> (raw)
In-Reply-To: <87d1ho953w.fsf@gmail.com> (message from Tino Calancha on Tue, 22 Nov 2016 01:20:51 +0900)

> From: Tino Calancha <tino.calancha@gmail.com>
> CC: emacs-devel@gnu.org, Tino Calancha <tino.calancha@gmail.com>
> Date: Tue, 22 Nov 2016 01:20:51 +0900
> 
> Thank you.  Following is the new patch after your comments:

We are close.

> +Lisp_Object
> +ash_lsh_impl (register Lisp_Object value, Lisp_Object count, bool lsh)

static Lisp_Object
ash_lsh_impl (register Lisp_Object value, Lisp_Object count, bool lsh)

> diff --git a/src/lisp.h b/src/lisp.h
> index e087828..c48c2c8 100644
> --- a/src/lisp.h
> +++ b/src/lisp.h
> @@ -602,6 +602,7 @@ extern void char_table_set (Lisp_Object, int, Lisp_Object);
>  /* Defined in data.c.  */
>  extern _Noreturn Lisp_Object wrong_type_argument (Lisp_Object, Lisp_Object);
>  extern _Noreturn void wrong_choice (Lisp_Object, Lisp_Object);
> +Lisp_Object ash_lsh_impl (Lisp_Object, Lisp_Object, bool);

No need to declare it here, as it is a static function used only in
the file in which it is defined.

Thanks.



  reply	other threads:[~2016-11-21 17:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-21 14:45 [PATCH] ash, lsh: Avoid code duplication Tino Calancha
2016-11-21 15:57 ` Eli Zaretskii
2016-11-21 16:20   ` Tino Calancha
2016-11-21 17:14     ` Eli Zaretskii [this message]
2016-11-22  2:17       ` Tino Calancha
2016-11-22 16:12         ` Eli Zaretskii
2016-11-22 16:16           ` Tino Calancha
2016-11-27  3:28           ` Tino Calancha
2016-11-22 16:48       ` Davis Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83bmx892lx.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=tino.calancha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.