From: Eli Zaretskii <eliz@gnu.org>
To: Philipp Stephani <phst@google.com>
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-25 d4e1549: Guard terminal parameter in XTerm mouse mode
Date: Wed, 23 Nov 2016 17:54:23 +0200 [thread overview]
Message-ID: <83bmx66vkg.fsf@gnu.org> (raw)
In-Reply-To: <CAP-RRPt+co+orzTdaZcb=mrnCd_LYMmpLJ1A_AJR=dSLX4wX-A@mail.gmail.com> (message from Philipp Stephani on Wed, 23 Nov 2016 12:20:16 +0000)
> From: Philipp Stephani <phst@google.com>
> Date: Wed, 23 Nov 2016 12:20:16 +0000
>
> Stefan Monnier <monnier@iro.umontreal.ca> schrieb am Mi., 23. Nov. 2016 um 02:08 Uhr:
>
> > + (setf (terminal-parameter nil 'xterm-mouse-last-down)
> > + ;; EVENT might be handed back to the input queue, which
> > + ;; might modify it. Copy it into the terminal parameter
> > + ;; to guard against that.
> > + (copy-sequence event))
>
> Do you have further information about when/where events might be
> modified in place? It sounds like a risky operation.
>
> I assume it's in the code that translates consecutive mouse-down events to mouse-movement events. It's
> easy to reproduce in HTerm: without the patch, dragging the mouse while holding a button causes
> "drag-mouse-0" events to be generated. These come from spurious mouse-movement events in
> xterm-mouse-last-down. Since nothing places these events explicitly there, the root cause must be that the
> event list is overwritten.
> Agreed that the input loop probably shouldn't modify event objects. But it might be a necessary optimization
> somewhere. Unfortunately I wasn't able to find the specific piece of code responsible for this modification.
Does this have to be applied to the release branch? If so, can you
tell why?
next prev parent reply other threads:[~2016-11-23 15:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20161122204222.29398.86534@vcs.savannah.gnu.org>
[not found] ` <20161122204222.DBE712201C5@vcs.savannah.gnu.org>
2016-11-23 1:08 ` [Emacs-diffs] emacs-25 d4e1549: Guard terminal parameter in XTerm mouse mode Stefan Monnier
2016-11-23 12:20 ` Philipp Stephani
2016-11-23 15:54 ` Eli Zaretskii [this message]
2016-11-23 17:09 ` Philipp Stephani
2016-11-23 17:22 ` Eli Zaretskii
2016-11-24 8:58 ` Philipp Stephani
2016-11-24 16:23 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bmx66vkg.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=phst@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.