From: Eli Zaretskii <eliz@gnu.org>
To: Philippe Vaucher <philippe.vaucher@gmail.com>
Cc: michael.albinus@gmx.de, 24985@debbugs.gnu.org
Subject: bug#24985: Add missing provide statements
Date: Fri, 25 Nov 2016 12:27:26 +0200 [thread overview]
Message-ID: <83bmx34zxt.fsf@gnu.org> (raw)
In-Reply-To: <CAGK7Mr4NTD4q2b+w_ifJeTSmXXNUa8yqqsSzsHYfhhwG9xtNOg@mail.gmail.com> (message from Philippe Vaucher on Tue, 22 Nov 2016 14:58:19 +0100)
> From: Philippe Vaucher <philippe.vaucher@gmail.com>
> Date: Tue, 22 Nov 2016 14:58:19 +0100
> Cc: 24985@debbugs.gnu.org
>
> > (defalias 'toggle-auto-composition 'auto-composition-mode)
> >
> > +(provide 'auto-composition-mode)
>
> Why that? I would expect (provide 'composite) here.
>
> I thought that the most interesting thing in composite was auto-composition-mode... same reasoning for
> replace.el which provided 'occur in my first patch.
>
> Anyway, you're right, it's not very consistent. Here attached is a new patch that simply follows the file name.
Thanks, pushed to master.
In the future, please start each sentence in the log entry with a
capital letter, and end it with a period. Here's how I reformatted
your log message:
* lisp/composite.el:
* lisp/replace.el:
* lisp/textmodes/text-mode.el: Add provide statement.
next prev parent reply other threads:[~2016-11-25 10:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 10:42 bug#24985: Add missing provide statements Philippe Vaucher
2016-11-22 12:15 ` Michael Albinus
2016-11-22 13:58 ` Philippe Vaucher
2016-11-22 15:13 ` Michael Albinus
2016-11-23 9:26 ` Philippe Vaucher
2016-11-23 9:46 ` Michael Albinus
2016-11-25 10:27 ` Eli Zaretskii [this message]
2016-11-25 11:51 ` Philippe Vaucher
2016-11-26 1:07 ` Richard Stallman
2016-11-26 7:17 ` Eli Zaretskii
2016-11-26 9:17 ` Michael Albinus
2016-11-26 10:07 ` Philippe Vaucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bmx34zxt.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=24985@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
--cc=philippe.vaucher@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.