From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el Date: Thu, 01 Dec 2016 19:17:27 +0200 Message-ID: <83bmwvpo0o.fsf@gnu.org> References: <6d0c8c2e-8428-2fdb-0d6e-899f7b9d7ffd@nifty.com> <8053af81-80e1-a24a-f649-8ffc86963ed5@nifty.com> <0cc7fab4-9a2c-6a8d-def7-36bd50317ca3@yandex.ru> <7f9a799f-de88-fd78-0cdc-dac0928f1503@nifty.com> <308bb78f-8be3-092d-d877-e129d340242b@nifty.com> <4dc615e7-ec73-60a5-426e-0d6986f15d76@yandex.ru> <0cb406fb-ffc4-a4ad-557a-2cacc99b8e75@nifty.com> <86ccb4af-5719-c017-26bb-fc06b4c904d2@yandex.ru> <83r35uxkr5.fsf@gnu.org> <4e12d4ad-cd6b-3087-5d7c-449d4c1886e2@yandex.ru> <83lgw1q9uu.fsf@gnu.org> <83eg1tq8is.fsf@gnu.org> <787e5206-53e0-752f-a339-4608d2f7ad39@yandex.ru> <837f7lq6lg.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1480612735 31093 195.159.176.226 (1 Dec 2016 17:18:55 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 1 Dec 2016 17:18:55 +0000 (UTC) Cc: p.stephani2@gmail.com, emacs-devel@gnu.org, larsi@gnus.org, kentaro.nakazawa@nifty.com To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 01 18:18:51 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCV0U-0007De-FE for ged-emacs-devel@m.gmane.org; Thu, 01 Dec 2016 18:18:50 +0100 Original-Received: from localhost ([::1]:57653 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCV0Y-0000sw-Aj for ged-emacs-devel@m.gmane.org; Thu, 01 Dec 2016 12:18:54 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39170) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCUzU-0000HS-Od for emacs-devel@gnu.org; Thu, 01 Dec 2016 12:17:52 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cCUzP-0001sB-Ne for emacs-devel@gnu.org; Thu, 01 Dec 2016 12:17:48 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52418) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCUzP-0001s6-Ki; Thu, 01 Dec 2016 12:17:43 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3806 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cCUzJ-0002gT-H3; Thu, 01 Dec 2016 12:17:40 -0500 In-reply-to: (message from Dmitry Gutov on Thu, 1 Dec 2016 02:30:15 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209882 Archived-At: > Cc: p.stephani2@gmail.com, larsi@gnus.org, kentaro.nakazawa@nifty.com, > emacs-devel@gnu.org > From: Dmitry Gutov > Date: Thu, 1 Dec 2016 02:30:15 +0200 > > On 30.11.2016 18:23, Eli Zaretskii wrote: > > > Since both the original issue and this one are at least indirectly > > caused by jason.el, it might make sense. > > Triggered, more like. Nothing wrong with that. If some issue isn't a bug, but gets in the way of a broad class of applications, it is okay to silently DTRT for that class only, in some central place that serves the class. > Either way, I don't think it's a great idea. Quite the opposite: by > allowing the programmer to avoid calling `encode-coding-string' in more > cases, we'll just make the problem in their code harder to find, until > some user of that code really does need to transfer multibyte content. I don't think we will win any hearts by nagging application programmers when we could silently DTRT ourselves. > Further, now that Emacs 25 is out, and we are allowed to have more > breaking changes in Emacs 26, I think we should change the check at the > end of url-http-create-request to just use multibyte-string-p. > > Barring some unforeseen consequences, this will solidify the requirement > that the caller need to deal with encoding explicitly in all cases, > before passing the request body to the transport level. Can you show me a patch to that effect, or point me to where it was posted in the past? I'm afraid I no longer remember those details. Thanks.