From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.comp.lib.gnulib.bugs,gmane.emacs.devel Subject: Re: [Emacs-diffs] master 085c7f6 2/2: Test format-time-string with zone arg Date: Tue, 02 May 2017 20:09:27 +0300 Message-ID: <83bmrbi3so.fsf@gnu.org> References: <20170427222412.28742.14016@vcs0.savannah.gnu.org> <20170427222413.8FBA722040@vcs0.savannah.gnu.org> <07e00044-4ce1-bba8-2fe5-4e7eb7fb27a6@cornell.edu> <269c5353-d07b-5cf0-4009-3d817351c470@cs.ucla.edu> <83h915ja41.fsf@gnu.org> <175dace6-c544-a0ac-2e96-b378b3c6f49d@cs.ucla.edu> <83shkoid2k.fsf@gnu.org> <8836de3f-eeda-ec8d-fff1-ef68ec808389@cs.ucla.edu> <83pofrixf4.fsf@gnu.org> <80850259-8972-19b3-6435-2b8b9cc2319b@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1493745038 31480 195.159.176.226 (2 May 2017 17:10:38 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 2 May 2017 17:10:38 +0000 (UTC) Cc: bug-gnulib@gnu.org, bruno@clisp.org, kbrown@cornell.edu, emacs-devel@gnu.org To: Paul Eggert Original-X-From: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane.org@gnu.org Tue May 02 19:10:32 2017 Return-path: Envelope-to: gnu-bug-gnulib@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d5bJm-0007xX-8j for gnu-bug-gnulib@m.gmane.org; Tue, 02 May 2017 19:10:30 +0200 Original-Received: from localhost ([::1]:60312 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5bJn-00044p-4T for gnu-bug-gnulib@m.gmane.org; Tue, 02 May 2017 13:10:31 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43209) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5bJZ-00043z-1o for bug-gnulib@gnu.org; Tue, 02 May 2017 13:10:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d5bJV-0001os-0o for bug-gnulib@gnu.org; Tue, 02 May 2017 13:10:16 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33319) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5bJU-0001ol-TU; Tue, 02 May 2017 13:10:12 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3113 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d5bJR-0002Ts-Ss; Tue, 02 May 2017 13:10:12 -0400 In-reply-to: <80850259-8972-19b3-6435-2b8b9cc2319b@cs.ucla.edu> (message from Paul Eggert on Tue, 2 May 2017 00:52:03 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane.org@gnu.org Original-Sender: "bug-gnulib" Xref: news.gmane.org gmane.comp.lib.gnulib.bugs:37213 gmane.emacs.devel:214522 Archived-At: > Cc: kbrown@cornell.edu, emacs-devel@gnu.org, Bruno Haible , > Gnulib bugs > From: Paul Eggert > Date: Tue, 2 May 2017 00:52:03 -0700 > > > the utimens.c file you've brought from Gnulib has 2 problems: > > > > . it defines WIN32_LEAN_AND_MEAN unconditionally, which conflicts > > with our own definition in nt/inc/ms-w32.h, which is processed > > earlier; > > > > . it includes msvc-nothrow.h, which is absent in the repository, it > > should have been imported from Gnulib together with utimens.c > > > > I fixed the first of these temporarily, in a way that at least GCC > > lets utimens.c compile, but I think in general utimens.c should do > > > > #ifndef WIN32_LEAN_AND_MEAN > > # define WIN32_LEAN_AND_MEAN > > #endif > > > > to avoid possible clashes with definitions elsewhere in the sources. > > I'd like Bruno's opinion on the macro clash, and on the attached patch for the > msvc-nothrow.h issue, a patch that I installed into Gnulib and into Emacs master > to try to get the Emacs master build working again. Thanks. > -#if (defined _WIN32 || defined __WIN32__) && ! defined __CYGWIN__ > +/* On native Windows, use SetFileTime; but avoid this when compiling > + GNU Emacs, which arranges for this in some other way and which > + defines WIN32_LEAN_AND_MEAN itself. */ That "other way" is the implementation of fdutimens in Emacs's w32.c. Perhaps Bruno could look at that implementation and comment on its merits and demerits vs the Gnulib implementation, and we could then decide whether to start using the Gnulib implementation, augmenting ours, or something else.