From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#27238: 24.5; Rename `face-spec-set-2' and give it a better doc string Date: Mon, 05 Jun 2017 20:11:48 +0300 Message-ID: <83bmq29x63.fsf@gnu.org> References: <<<<<06a7cc83-a2a8-45a0-97d4-bd3a478aab92@default>>>>> <<<<<83wp8ra9g6.fsf@gnu.org>>>>> <<<<26a213b3-908e-43b1-a009-b8a18f0a1c23@default>>>> <<<<83tw3v9njh.fsf@gnu.org>>>> <<>> <<<83lgp6a257.fsf@gnu.org>>> <<139eede5-534a-47ad-805a-bad9995526eb@default>> <<83d1ai9yy1.fsf@gnu.org>> <2ceee035-593d-4831-be30-06443ba3bc92@default> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1496682835 22798 195.159.176.226 (5 Jun 2017 17:13:55 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 5 Jun 2017 17:13:55 +0000 (UTC) Cc: 27238@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 05 19:13:52 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHvZe-0005eB-De for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Jun 2017 19:13:50 +0200 Original-Received: from localhost ([::1]:34463 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dHvZj-000868-Li for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Jun 2017 13:13:55 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36628) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dHvYw-0007Vi-IO for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2017 13:13:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dHvYs-0001dk-B6 for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2017 13:13:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55318) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dHvYs-0001dP-7w for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2017 13:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dHvYs-0004QP-2R for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2017 13:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Jun 2017 17:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27238 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27238-submit@debbugs.gnu.org id=B27238.149668272916951 (code B ref 27238); Mon, 05 Jun 2017 17:13:02 +0000 Original-Received: (at 27238) by debbugs.gnu.org; 5 Jun 2017 17:12:09 +0000 Original-Received: from localhost ([127.0.0.1]:57995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHvY1-0004PL-F8 for submit@debbugs.gnu.org; Mon, 05 Jun 2017 13:12:09 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:45063) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHvXz-0004P7-7H for 27238@debbugs.gnu.org; Mon, 05 Jun 2017 13:12:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dHvXp-0000sl-Sx for 27238@debbugs.gnu.org; Mon, 05 Jun 2017 13:12:02 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42761) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dHvXp-0000sZ-Oq; Mon, 05 Jun 2017 13:11:57 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1640 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dHvXo-0006hw-V5; Mon, 05 Jun 2017 13:11:57 -0400 In-reply-to: <2ceee035-593d-4831-be30-06443ba3bc92@default> (message from Drew Adams on Mon, 5 Jun 2017 09:40:18 -0700 (PDT)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133309 Archived-At: > Date: Mon, 5 Jun 2017 09:40:18 -0700 (PDT) > From: Drew Adams > Cc: 27238@debbugs.gnu.org > > > > "set one face (`fringe' or whatever), in only a given frame, > > > ^^^^^^^^^^^^^^^^^^^^^ > > > to the spec of another face (or to a spec that isn't yet used > > > for any face)" > > > > > > I don't see a "higher-level function" that does that. I don't > > > see any function that does, apart from `face-spec-2'. > > > > Doesn't this boil down to setting the attributes of the target face to > > the values of the same attributes of the source face? > > Yes, of course, which is why `face-spec-set-2' does that: No, it also consults face-x-resources, which is not necessarily what the caller wants. > Are suggesting that everyone who needs to "set the attributes > of the target face to the values of the same attributes of the > source face" should just write such an explicit loop (repeat > the body of `face-spec-set-2') instead of just calling > `face-spec-set-2'? Are you suggesting that for every loop someone might possibly need at some point we should have a documented and public function in Emacs? > Or are you hinting that there is some other "higher-level > function" that already does exactly that? Well, there's defface with :inherit, and there's copy-face, to name just two. You didn't describe enough context of what you want to do, so I cannot be sure they are not relevant.