From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28033: [PATCH] Add new face 'header-line-highlight' Date: Sun, 13 Aug 2017 17:27:04 +0300 Message-ID: <83bmnjilvr.fsf@gnu.org> References: <87bmno7228.fsf@lylat> <83k22crrfg.fsf@gnu.org> <874ltg6l2k.fsf@lylat> <83k22aqdwd.fsf@gnu.org> <87mv75iwn9.fsf@lylat> <83a835qml8.fsf@gnu.org> <8760dsmak9.fsf@lylat> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1502634493 8125 195.159.176.226 (13 Aug 2017 14:28:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 13 Aug 2017 14:28:13 +0000 (UTC) Cc: 28033@debbugs.gnu.org To: Alex Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 13 16:28:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dgts6-0001f6-Em for geb-bug-gnu-emacs@m.gmane.org; Sun, 13 Aug 2017 16:28:07 +0200 Original-Received: from localhost ([::1]:55757 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dgtsB-0002z3-6Q for geb-bug-gnu-emacs@m.gmane.org; Sun, 13 Aug 2017 10:28:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39312) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dgts5-0002xK-Ag for bug-gnu-emacs@gnu.org; Sun, 13 Aug 2017 10:28:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dgts2-0007TI-2m for bug-gnu-emacs@gnu.org; Sun, 13 Aug 2017 10:28:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50774) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dgts1-0007TE-Ux for bug-gnu-emacs@gnu.org; Sun, 13 Aug 2017 10:28:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dgts1-0003wN-Lf for bug-gnu-emacs@gnu.org; Sun, 13 Aug 2017 10:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Aug 2017 14:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28033 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28033-submit@debbugs.gnu.org id=B28033.150263444415137 (code B ref 28033); Sun, 13 Aug 2017 14:28:01 +0000 Original-Received: (at 28033) by debbugs.gnu.org; 13 Aug 2017 14:27:24 +0000 Original-Received: from localhost ([127.0.0.1]:59454 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dgtrQ-0003w5-3F for submit@debbugs.gnu.org; Sun, 13 Aug 2017 10:27:24 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:48195) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dgtrO-0003vz-9A for 28033@debbugs.gnu.org; Sun, 13 Aug 2017 10:27:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dgtrF-0007Je-2g for 28033@debbugs.gnu.org; Sun, 13 Aug 2017 10:27:17 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58582) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dgtrE-0007Ja-VH; Sun, 13 Aug 2017 10:27:12 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3310 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dgtrE-0004tG-Cs; Sun, 13 Aug 2017 10:27:12 -0400 In-reply-to: <8760dsmak9.fsf@lylat> (message from Alex on Sat, 12 Aug 2017 21:05:42 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135723 Archived-At: > From: Alex > Cc: 28033-done@debbugs.gnu.org > Date: Sat, 12 Aug 2017 21:05:42 -0600 > > > . The order of the references to various parts of the changes in the > > log message should assume the reading order of top to bottom, so > > the log message might need some minor reordering. In this case, > > your original order: > > I was going for a mostly alphabetical ordering. I take it that doesn't > matter? > > >> * doc/emacs/display.texi (Standard Faces): > >> * etc/NEWS: Document the face. > >> * lisp/emacs-lisp/tabulated-list.el (tabulated-list-init-header): > >> * lisp/info.el (Info-fontify-node): Use the face. > >> * lisp/faces.el: Define the face. > > > > refers to "the face" before it was defined. I've reordered it to > > put the reference to the lisp/faces.el change before all the rest. > > I don't really understand this part (though I don't mind following it). > Only the commit summary line references the face by name, and the > summary is already at the top. Why does it matter that, in the actual > program execution, the face has to be defined first? Well, the logical order is: first you introduce the face, then you use it, then you document it. So it'd be nice to have the log message read this way, top to bottom. In your case, it was in the reverse order, probably because "C-x 4 a" puts the entries in LIFO order. Admittedly, this is a very minor aesthetic issue. > P.S. I happened upon two more places to add this face to. Would you > please push this as well? Will do, thanks.