From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-26 ee512e9: Ignore buffers whose name begins with a space in save-some-buffers Date: Fri, 22 Sep 2017 20:21:03 +0300 Message-ID: <83bmm2d4zk.fsf@gnu.org> References: <20170918202953.21378.63492@vcs0.savannah.gnu.org> <20170918202955.5043420AC4@vcs0.savannah.gnu.org> <87inge8skl.fsf@ericabrahamsen.net> <878th9z40r.fsf@ericabrahamsen.net> <831sn0fpk9.fsf@gnu.org> <87o9q3lt8s.fsf@ericabrahamsen.net> <83zi9ncjg2.fsf@gnu.org> <87d16iivcx.fsf@ericabrahamsen.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1506100926 9551 195.159.176.226 (22 Sep 2017 17:22:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 22 Sep 2017 17:22:06 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eric Abrahamsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 22 19:22:01 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvReJ-00026V-D4 for ged-emacs-devel@m.gmane.org; Fri, 22 Sep 2017 19:21:59 +0200 Original-Received: from localhost ([::1]:60319 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvReQ-0001rF-Rx for ged-emacs-devel@m.gmane.org; Fri, 22 Sep 2017 13:22:06 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33296) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvRdW-0001oy-CZ for emacs-devel@gnu.org; Fri, 22 Sep 2017 13:21:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dvRdT-0007pf-Mv for emacs-devel@gnu.org; Fri, 22 Sep 2017 13:21:10 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43843) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvRdT-0007pa-JO; Fri, 22 Sep 2017 13:21:07 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4782 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dvRdS-000575-Vv; Fri, 22 Sep 2017 13:21:07 -0400 In-reply-to: <87d16iivcx.fsf@ericabrahamsen.net> (message from Eric Abrahamsen on Fri, 22 Sep 2017 08:52:30 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:218692 Archived-At: > From: Eric Abrahamsen > Date: Fri, 22 Sep 2017 08:52:30 -0700 > > (and pred > (progn > (set-buffer buffer) > (and buffer-offer-save (> (buffer-size) 0)))) > > Unless a user has customized `save-some-buffers-default-predicate', PRED > is only t when Emacs is exiting. > > I don't understand why it's being used this way, or why > `save-some-buffers' should behave differently when called interactively > vs when Emacs is exiting, but I didn't want to touch it because, as has > been pointed out, it's been this way for decades. Does VCS history explain why PRED is used like that?