From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28615: [PATCH] Clarify what grep-read-files wants Date: Tue, 10 Oct 2017 10:52:01 +0300 Message-ID: <83bmlfqw2m.fsf@gnu.org> References: <83wp44qvzw.fsf@gnu.org> <83k203r1gx.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1507622004 25693 195.159.176.226 (10 Oct 2017 07:53:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 10 Oct 2017 07:53:24 +0000 (UTC) Cc: 28615@debbugs.gnu.org To: Allen Li Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 10 09:53:19 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1pLm-00057w-4o for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Oct 2017 09:53:14 +0200 Original-Received: from localhost ([::1]:33329 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1pLq-0007PX-EK for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Oct 2017 03:53:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44222) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1pLd-0007MU-NE for bug-gnu-emacs@gnu.org; Tue, 10 Oct 2017 03:53:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e1pLa-0004PP-Lg for bug-gnu-emacs@gnu.org; Tue, 10 Oct 2017 03:53:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50386) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e1pLa-0004PL-HE for bug-gnu-emacs@gnu.org; Tue, 10 Oct 2017 03:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e1pLa-000659-7t for bug-gnu-emacs@gnu.org; Tue, 10 Oct 2017 03:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Oct 2017 07:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28615 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28615-submit@debbugs.gnu.org id=B28615.150762194823340 (code B ref 28615); Tue, 10 Oct 2017 07:53:02 +0000 Original-Received: (at 28615) by debbugs.gnu.org; 10 Oct 2017 07:52:28 +0000 Original-Received: from localhost ([127.0.0.1]:59067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1pL1-00064N-OM for submit@debbugs.gnu.org; Tue, 10 Oct 2017 03:52:27 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53091) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1pKz-000646-Cx for 28615@debbugs.gnu.org; Tue, 10 Oct 2017 03:52:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e1pKq-0004At-Sv for 28615@debbugs.gnu.org; Tue, 10 Oct 2017 03:52:20 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48120) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1pKq-0004Ai-PQ; Tue, 10 Oct 2017 03:52:16 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1800 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e1pKp-0000av-S7; Tue, 10 Oct 2017 03:52:16 -0400 In-reply-to: (message from Allen Li on Mon, 9 Oct 2017 23:51:47 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138151 Archived-At: > From: Allen Li > Date: Mon, 9 Oct 2017 23:51:47 -0700 > Cc: 28615@debbugs.gnu.org > > Are you saying that a user might mistake the completion on > grep-files-aliases as completion on file name? Something like that, yes. In general, I don't think completing on wildcards is useful. > I believe that with the new prompt change, that is unlikely. People don't always read the prompt paying attention to every word of it, and "all" is a valid wildcard anyway. > >> As I noted in the bug, most of the completions that would be > >> provided by read-file-name-internal don't work > > > > IMO, that's okay, because wildcards cannot be meaningfully completed > > on. > > But the aliases from grep-files-aliases can be meaningfully > completed. I don't see why we shouldn't provide meaningful > completion if the user defines a lot of aliases, seeing as how > the current file name completion is useless. I didn't think allowing it to complete on 2 non-file values is important enough to justify the possible confusion.