From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: windows installer Date: Sat, 25 Nov 2017 14:56:35 +0200 Message-ID: <83bmjq8qkc.fsf@gnu.org> References: <795606216.288650.1510476987589@mail.libero.it> <83po8nn38p.fsf@gnu.org> <8760adbxw6.fsf@russet.org.uk> <1369184752.491791.1510670215753@mail.libero.it> <1447748875.458066.1510690344828@mail.libero.it> <1511167607.4167724.1178177216.0DCA23E2@webmail.messagingengine.com> <87k1yh535q.fsf@russet.org.uk> <83efopbqxk.fsf@gnu.org> <87vai098f5.fsf@russet.org.uk> <83zi7cah9k.fsf@gnu.org> <87efon1odg.fsf@russet.org.uk> <83tvxj8n8v.fsf@gnu.org> <87indyfwf7.fsf@russet.org.uk> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1511614627 14542 195.159.176.226 (25 Nov 2017 12:57:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 25 Nov 2017 12:57:07 +0000 (UTC) Cc: jostein@kjonigsen.net, jostein@secure.kjonigsen.net, emacs-devel@gnu.org To: phillip.lord@russet.org.uk (Phillip Lord) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 25 13:57:03 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eIa0z-0003Nq-NE for ged-emacs-devel@m.gmane.org; Sat, 25 Nov 2017 13:57:01 +0100 Original-Received: from localhost ([::1]:52910 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eIa17-0000Ag-5H for ged-emacs-devel@m.gmane.org; Sat, 25 Nov 2017 07:57:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53616) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eIa0w-0000Ab-3p for emacs-devel@gnu.org; Sat, 25 Nov 2017 07:56:58 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eIa0s-0000Bl-6h for emacs-devel@gnu.org; Sat, 25 Nov 2017 07:56:58 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56412) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eIa0s-0000Be-2u; Sat, 25 Nov 2017 07:56:54 -0500 Original-Received: from [176.228.60.248] (port=3890 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eIa0q-0002MR-Ce; Sat, 25 Nov 2017 07:56:53 -0500 In-reply-to: <87indyfwf7.fsf@russet.org.uk> (phillip.lord@russet.org.uk) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:220451 Archived-At: > From: phillip.lord@russet.org.uk (Phillip Lord) > Cc: jostein@secure.kjonigsen.net, jostein@kjonigsen.net, emacs-devel@gnu.org > Date: Sat, 25 Nov 2017 11:08:12 +0000 > > >> (defconst emacs-build-system > >> (if (file-exists-p "~/.emacs-build-system-name") > >> (with-temp-buffer > >> (insert-file-contents "~/.emacs-build-system-name") > >> (buffer-string)) > >> (system-name))) > > > > Where do you want to put this? Are you going to patch the sources > > from which you produce the binaries? > > master Then I think a much better way would be to access some environment variable instead of a file. (Assuming there's no way for you to arrange for that system to return some string of your liking as the system name -- if that's possible, it would be preferable, because having in our code something that caters to building installable binaries on MS-Windows is not something I'd do happily.)