From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-26 f274cbd: Avoid reordering of output in 'shr-insert-document' Date: Sat, 16 Dec 2017 18:04:16 +0200 Message-ID: <83bmiyslq7.fsf@gnu.org> References: <20171216141055.30854.67661@vcs0.savannah.gnu.org> <20171216141056.8391A24612@vcs0.savannah.gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1513440271 2577 195.159.176.226 (16 Dec 2017 16:04:31 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 16 Dec 2017 16:04:31 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 16 17:04:26 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eQEwr-0000DR-4T for ged-emacs-devel@m.gmane.org; Sat, 16 Dec 2017 17:04:25 +0100 Original-Received: from localhost ([::1]:51128 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eQEwy-0002B9-3F for ged-emacs-devel@m.gmane.org; Sat, 16 Dec 2017 11:04:32 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52419) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eQEwr-0002B0-TE for emacs-devel@gnu.org; Sat, 16 Dec 2017 11:04:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eQEwo-0000yK-QO for emacs-devel@gnu.org; Sat, 16 Dec 2017 11:04:25 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35367) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eQEwo-0000yD-MM; Sat, 16 Dec 2017 11:04:22 -0500 Original-Received: from [176.228.60.248] (port=3520 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eQEwn-00076x-K6; Sat, 16 Dec 2017 11:04:22 -0500 In-reply-to: (message from Stefan Monnier on Sat, 16 Dec 2017 10:04:06 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221129 Archived-At: > From: Stefan Monnier > Cc: Eli Zaretskii > Date: Sat, 16 Dec 2017 10:04:06 -0500 > > > + ;; Save and restore point across with-temp-buffer, since > > + ;; shr-pixel-column uses save-window-excursion, which can reset > > + ;; point to 1. > > + (let ((pt (point))) > > + (with-temp-buffer > > + (insert string) > > + (shr-pixel-column)) > > + (goto-char pt)))) > > Is it possible to fix the problem in shr-pixel-column (since, according > to the comment above, the problems comes from there)? No, because the value of point to preserve is from the buffer which was current before with-temp-buffer.