From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-26 f274cbd: Avoid reordering of output in 'shr-insert-document'
Date: Sat, 16 Dec 2017 18:04:16 +0200 [thread overview]
Message-ID: <83bmiyslq7.fsf@gnu.org> (raw)
In-Reply-To: <jwvh8sqlnqi.fsf-monnier+emacsdiffs@gnu.org> (message from Stefan Monnier on Sat, 16 Dec 2017 10:04:06 -0500)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Sat, 16 Dec 2017 10:04:06 -0500
>
> > + ;; Save and restore point across with-temp-buffer, since
> > + ;; shr-pixel-column uses save-window-excursion, which can reset
> > + ;; point to 1.
> > + (let ((pt (point)))
> > + (with-temp-buffer
> > + (insert string)
> > + (shr-pixel-column))
> > + (goto-char pt))))
>
> Is it possible to fix the problem in shr-pixel-column (since, according
> to the comment above, the problems comes from there)?
No, because the value of point to preserve is from the buffer which
was current before with-temp-buffer.
next prev parent reply other threads:[~2017-12-16 16:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171216141055.30854.67661@vcs0.savannah.gnu.org>
[not found] ` <20171216141056.8391A24612@vcs0.savannah.gnu.org>
2017-12-16 15:04 ` [Emacs-diffs] emacs-26 f274cbd: Avoid reordering of output in 'shr-insert-document' Stefan Monnier
2017-12-16 16:04 ` Eli Zaretskii [this message]
2017-12-16 22:23 ` Stefan Monnier
2017-12-17 15:44 ` Eli Zaretskii
2017-12-17 17:54 ` martin rudalics
2017-12-17 20:22 ` Eli Zaretskii
2017-12-17 21:20 ` martin rudalics
2017-12-18 3:09 ` Stefan Monnier
2017-12-18 7:26 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bmiyslq7.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.