From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Suboptimal bug fix in CC Mode. Date: Tue, 16 Jan 2018 19:53:56 +0200 Message-ID: <83bmhty9jf.fsf@gnu.org> References: <20180115220012.GA4477@ACM> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1516126510 23796 195.159.176.226 (16 Jan 2018 18:15:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 16 Jan 2018 18:15:10 +0000 (UTC) Cc: emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 16 19:15:06 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebVlJ-0005ve-O5 for ged-emacs-devel@m.gmane.org; Tue, 16 Jan 2018 19:15:05 +0100 Original-Received: from localhost ([::1]:52779 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebVnJ-0004fD-GC for ged-emacs-devel@m.gmane.org; Tue, 16 Jan 2018 13:17:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46705) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebVR3-00035Q-Ov for emacs-devel@gnu.org; Tue, 16 Jan 2018 12:54:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebVQz-0004jB-UE for emacs-devel@gnu.org; Tue, 16 Jan 2018 12:54:09 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45027) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebVQz-0004j3-QY; Tue, 16 Jan 2018 12:54:05 -0500 Original-Received: from [176.228.60.248] (port=1660 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ebVQz-00072U-8J; Tue, 16 Jan 2018 12:54:05 -0500 In-reply-to: <20180115220012.GA4477@ACM> (message from Alan Mackenzie on Mon, 15 Jan 2018 22:00:12 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222021 Archived-At: > Date: Mon, 15 Jan 2018 22:00:12 +0000 > Cc: emacs-devel@gnu.org > From: Alan Mackenzie > > I don't think we should leave this bug in Emacs-26. Agreed. > Clearly, analysing the innards of "{ ... }" is not a reliable way to > distinguish brace blocks from statement/defun blocks. Instead, more > elaborate analysis of its context needs to be carried out. This fix > will be quite involved, and will be considerably more extensive than a > "one-line fix". > > Alternatively, the C99 compound literals feature could be removed from > Emacs-26 and postponed till Emacs-27. I suggest that you revert the fix from the release branch, but leave it on master, and try to fix it there. Please mark the revert as "not to be merged to master". Thanks. > Sorry. No sweat.