all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Alan Mackenzie <acm@muc.de>
Cc: emacs-devel@gnu.org
Subject: Re: Suboptimal bug fix in CC Mode.
Date: Tue, 16 Jan 2018 19:53:56 +0200	[thread overview]
Message-ID: <83bmhty9jf.fsf@gnu.org> (raw)
In-Reply-To: <20180115220012.GA4477@ACM> (message from Alan Mackenzie on Mon,  15 Jan 2018 22:00:12 +0000)

> Date: Mon, 15 Jan 2018 22:00:12 +0000
> Cc: emacs-devel@gnu.org
> From: Alan Mackenzie <acm@muc.de>
> 
> I don't think we should leave this bug in Emacs-26.

Agreed.

> Clearly, analysing the innards of "{ ... }" is not a reliable way to
> distinguish brace blocks from statement/defun blocks.  Instead, more
> elaborate analysis of its context needs to be carried out.  This fix
> will be quite involved, and will be considerably more extensive than a
> "one-line fix".
> 
> Alternatively, the C99 compound literals feature could be removed from
> Emacs-26 and postponed till Emacs-27.

I suggest that you revert the fix from the release branch, but leave
it on master, and try to fix it there.  Please mark the revert as "not
to be merged to master".

Thanks.

> Sorry.

No sweat.



  reply	other threads:[~2018-01-16 17:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-15 22:00 Suboptimal bug fix in CC Mode Alan Mackenzie
2018-01-16 17:53 ` Eli Zaretskii [this message]
2018-01-18 18:00   ` Alan Mackenzie
2018-01-23  8:50     ` John Wiegley
2018-01-21 18:37   ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83bmhty9jf.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=acm@muc.de \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.