From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master fails to build on FreeBSD when ACL support is on Date: Sat, 20 Jan 2018 09:57:09 +0200 Message-ID: <83bmhpt12i.fsf@gnu.org> References: <86o9lua0yx.fsf@phe.ftfl.ca> <834lnly8ht.fsf@gnu.org> <86vafy20sj.fsf@phe.ftfl.ca> <83o9lpuct5.fsf@gnu.org> <83lggtu1qn.fsf@gnu.org> <9dd64b10-78ce-c561-8c51-9e15b11e102c@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1516434980 3597 195.159.176.226 (20 Jan 2018 07:56:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 20 Jan 2018 07:56:20 +0000 (UTC) Cc: monnier@IRO.UMontreal.CA, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 20 08:56:15 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eco0b-0000V2-Tm for ged-emacs-devel@m.gmane.org; Sat, 20 Jan 2018 08:56:14 +0100 Original-Received: from localhost ([::1]:50296 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eco2b-0004lV-VS for ged-emacs-devel@m.gmane.org; Sat, 20 Jan 2018 02:58:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55140) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eco1u-0004kr-07 for emacs-devel@gnu.org; Sat, 20 Jan 2018 02:57:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eco1q-0002sE-2y for emacs-devel@gnu.org; Sat, 20 Jan 2018 02:57:34 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49094) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eco1q-0002sA-0H; Sat, 20 Jan 2018 02:57:30 -0500 Original-Received: from [176.228.60.248] (port=3141 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eco1p-0002Xw-6j; Sat, 20 Jan 2018 02:57:29 -0500 In-reply-to: <9dd64b10-78ce-c561-8c51-9e15b11e102c@cs.ucla.edu> (message from Paul Eggert on Fri, 19 Jan 2018 14:42:40 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222104 Archived-At: > Cc: emacs-devel@gnu.org > From: Paul Eggert > Date: Fri, 19 Jan 2018 14:42:40 -0800 > > On 01/19/2018 12:53 PM, Stefan Monnier wrote: > > which seems to me to be the result of an oversight: the original coder > > probably didn't realize that such a call would either create the temp > > file in the same directory as target-file or under /tmp depending on > > whether target-file is relative or absolute. > > Right you are. (The "original coder" was me; sorry about that.) Since I > broke it, I fixed it by installing the attached into emacs-26. I've reverted it. Please make this change on master instead, and please don't make any non-trivial, non-documentation changes on emacs-26 without asking first. This particular issue has some history, and bumped into several different use cases, each one with its unique requirements. It's too late now to set us back to the beginning of that history on the release branch, because we will never be able to reliably test all those use cases in time for the release. More generally, someone who has access to FreeBSD and understands its ACL implementation should look into that, because it sounds like we have fundamental problems there with moving files from temp directory, and those problems are just waiting to bite us in random places, like this one. Thanks.