Re: master fails to build on FreeBSD when ACL support is on

[Eli Zaretskii <eliz@gnu.org>]

> Cc: emacs-devel@gnu.org
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Fri, 19 Jan 2018 14:42:40 -0800
> 
> On 01/19/2018 12:53 PM, Stefan Monnier wrote:
> > which seems to me to be the result of an oversight: the original coder
> > probably didn't realize that such a call would either create the temp
> > file in the same directory as target-file or under /tmp depending on
> > whether target-file is relative or absolute.
> 
> Right you are. (The "original coder" was me; sorry about that.) Since I 
> broke it, I fixed it by installing the attached into emacs-26.

I've reverted it.  Please make this change on master instead, and
please don't make any non-trivial, non-documentation changes on
emacs-26 without asking first.

This particular issue has some history, and bumped into several
different use cases, each one with its unique requirements.  It's too
late now to set us back to the beginning of that history on the
release branch, because we will never be able to reliably test all
those use cases in time for the release.

More generally, someone who has access to FreeBSD and understands its
ACL implementation should look into that, because it sounds like we
have fundamental problems there with moving files from temp directory,
and those problems are just waiting to bite us in random places, like
this one.

Thanks.