From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org
Subject: Re: Should Emacs 26 be portable to Glibc 2.28?
Date: Thu, 08 Mar 2018 15:39:13 +0200 [thread overview]
Message-ID: <83bmfyptz2.fsf@gnu.org> (raw)
In-Reply-To: <96913ef6-44d4-cd63-8a37-5080be2d22dc@cs.ucla.edu> (message from Paul Eggert on Wed, 7 Mar 2018 18:09:49 -0800)
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Wed, 7 Mar 2018 18:09:49 -0800
>
> The attached patch, which I've installed into Emacs master, fixes a
> incompatibility between Emacs and the planned 2.28 release of glibc.
> Should I install it into the emacs-26 branch? glibc 2.28 is currently
> scheduled for August, so this shouldn't be much of an issue until then;
> however, as the patch is reasonably conservative and it's likely there
> won't be another Emacs release before August, it might make sense to
> install this patch into the emacs-26 branch now.
>
> The underlying problem is that Emacs (via gnulib) mucks with glibc
> internals that are planned to change in glibc 2.28. For more see the
> thread here:
>
> https://lists.gnu.org/r/bug-gnulib/2018-03/msg00000.html
Thanks.
In the name of paranoia, would it be possible to make the first of
these two changes backward-compatible, by doing this instead:
> diff --git a/lib/fpending.c b/lib/fpending.c
> index c84e3a5b4e..789f50e4e4 100644
> --- a/lib/fpending.c
> +++ b/lib/fpending.c
> @@ -32,7 +32,7 @@ __fpending (FILE *fp)
> /* Most systems provide FILE as a struct and the necessary bitmask in
> <stdio.h>, because they need it for implementing getc() and putc() as
> fast macros. */
> -#if defined _IO_ftrylockfile || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */
> +#if defined _IO_ftrylockfile || defined _IO_EOF_SEEN || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */
> return fp->_IO_write_ptr - fp->_IO_write_base;
> #elif defined __sferror || defined __DragonFly__ || defined __ANDROID__
> /* FreeBSD, NetBSD, OpenBSD, DragonFly, Mac OS X, Cygwin, Minix 3, Android */
With that, I think we can safely install this on the release branch.
next prev parent reply other threads:[~2018-03-08 13:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 2:09 Should Emacs 26 be portable to Glibc 2.28? Paul Eggert
2018-03-08 13:39 ` Eli Zaretskii [this message]
2018-03-09 1:11 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bmfyptz2.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.