From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Heads-up: Emacs 26.1 RC1 Date: Tue, 20 Mar 2018 11:18:47 +0200 Message-ID: <83bmfjm7ew.fsf@gnu.org> References: <83605snjjt.fsf@gnu.org> <87605raoo9.fsf@killashandra.ballybran.fr> <83zi33n9ud.fsf@gnu.org> <87y3inalb5.fsf@killashandra.ballybran.fr> <83sh8vn7ss.fsf@gnu.org> <87r2of5las.fsf@ericabrahamsen.net> <83d0zzmd3b.fsf@gnu.org> <87muz35f33.fsf@ericabrahamsen.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1521537423 11931 195.159.176.226 (20 Mar 2018 09:17:03 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 20 Mar 2018 09:17:03 +0000 (UTC) Cc: johnw@gnu.org, emacs-devel@gnu.org, pierre.techoueyres@free.fr To: Eric Abrahamsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 20 10:16:58 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eyDO4-0002uc-I0 for ged-emacs-devel@m.gmane.org; Tue, 20 Mar 2018 10:16:57 +0100 Original-Received: from localhost ([::1]:46957 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyDQ2-000742-DE for ged-emacs-devel@m.gmane.org; Tue, 20 Mar 2018 05:18:58 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49020) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyDPp-00072z-2M for emacs-devel@gnu.org; Tue, 20 Mar 2018 05:18:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyDPo-0004jy-5r for emacs-devel@gnu.org; Tue, 20 Mar 2018 05:18:45 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47965) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyDPh-0004bg-9K; Tue, 20 Mar 2018 05:18:37 -0400 Original-Received: from [176.228.60.248] (port=4059 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eyDPg-0006dD-Mj; Tue, 20 Mar 2018 05:18:37 -0400 In-reply-to: <87muz35f33.fsf@ericabrahamsen.net> (message from Eric Abrahamsen on Tue, 20 Mar 2018 16:25:04 +0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:223853 Archived-At: > From: Eric Abrahamsen > Cc: pierre.techoueyres@free.fr, johnw@gnu.org, emacs-devel@gnu.org > Date: Tue, 20 Mar 2018 16:25:04 +0800 > > > The changes in error/warning messages and in the test suite are okay > > to go, but I'm worried by the 2 changes that add a condition (where > > you went from (when ...) to (cond ...)). Is this really necessary, > > and what problems do they solve? > > I know... Mostly it took so long because of testing. The test suite > changes are there to test the new code, which directly models errors > currently in the wild, and they can't go in by themselves. > > Very long story short, in Emacs 26 eieio objects went from being defined > as vectors to being defined as objects. This messed up how they are > serialized to disk using eieio-persistent. Two main consumers of > eieio-persistent (pcache and the Gnus registry) are currently broken > because of this. The `cond' statement is there to make sure that, in > these two packages, the objects are written correctly to disk. Which code/packages outside of CEDET use the affected functions?