From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31373: 26.1; frame-list-z-order segfaults on initial daemon frame Date: Mon, 07 May 2018 20:59:10 +0300 Message-ID: <83bmdrqrdd.fsf@gnu.org> References: <87sh747vsf.fsf@tcd.ie> <87efiona6i.fsf@gmail.com> <87muxcomoy.fsf@tcd.ie> <87bmdsn3z3.fsf@gmail.com> <5AEFF179.3090706@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1525715894 23745 195.159.176.226 (7 May 2018 17:58:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 7 May 2018 17:58:14 +0000 (UTC) Cc: npostavs@gmail.com, 31373@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 07 19:58:10 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fFkOk-0005yO-Hs for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 May 2018 19:58:06 +0200 Original-Received: from localhost ([::1]:47456 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fFkQr-0004xV-Io for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 May 2018 14:00:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52146) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fFkQi-0004xD-4X for bug-gnu-emacs@gnu.org; Mon, 07 May 2018 14:00:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fFkQc-0000uZ-Ei for bug-gnu-emacs@gnu.org; Mon, 07 May 2018 14:00:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45164) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fFkQc-0000uR-Bc for bug-gnu-emacs@gnu.org; Mon, 07 May 2018 14:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fFkQc-00062K-3F for bug-gnu-emacs@gnu.org; Mon, 07 May 2018 14:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 May 2018 18:00:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31373 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 31373-submit@debbugs.gnu.org id=B31373.152571596123133 (code B ref 31373); Mon, 07 May 2018 18:00:01 +0000 Original-Received: (at 31373) by debbugs.gnu.org; 7 May 2018 17:59:21 +0000 Original-Received: from localhost ([127.0.0.1]:53061 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fFkPx-000613-5L for submit@debbugs.gnu.org; Mon, 07 May 2018 13:59:21 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:60895) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fFkPv-00060s-IT for 31373@debbugs.gnu.org; Mon, 07 May 2018 13:59:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fFkPn-0008SX-7G for 31373@debbugs.gnu.org; Mon, 07 May 2018 13:59:14 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57234) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fFkPn-0008SK-42; Mon, 07 May 2018 13:59:11 -0400 Original-Received: from [176.228.60.248] (port=4932 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fFkPl-0000yK-N3; Mon, 07 May 2018 13:59:10 -0400 In-reply-to: <5AEFF179.3090706@gmx.at> (message from martin rudalics on Mon, 07 May 2018 08:26:01 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146063 Archived-At: > Date: Mon, 07 May 2018 08:26:01 +0200 > From: martin rudalics > > - if (XFRAME (frame)->output_data.x->parent_desc == children[i] > - || FRAME_OUTER_WINDOW (XFRAME (frame)) == children[i]) > + if (FRAME_X_P (frame) > + && (XFRAME (frame)->output_data.x->parent_desc == children[i] > + || FRAME_OUTER_WINDOW (XFRAME (frame)) == children[i])) > > Thank you. Eli, I think Noam should push this to 26.1, if still > possible. Why? The workaround is very simple: don't call that function in a daemon session that has no GUI frames.