From: Eli Zaretskii <eliz@gnu.org>
To: Noam Postavsky <npostavs@gmail.com>
Cc: ibmbull@yandex.ru, 32281@debbugs.gnu.org
Subject: bug#32281: shr.el align support patch
Date: Mon, 06 Aug 2018 18:13:18 +0300 [thread overview]
Message-ID: <83bmafsf3l.fsf@gnu.org> (raw)
In-Reply-To: <87wot4xl3g.fsf@gmail.com> (message from Noam Postavsky on Sun, 05 Aug 2018 22:52:35 -0400)
> From: Noam Postavsky <npostavs@gmail.com>
> Date: Sun, 05 Aug 2018 22:52:35 -0400
> Cc: 32281@debbugs.gnu.org
>
> Bad Blue Bull <ibmbull@yandex.ru> writes:
>
> > Here's a patch for shr.el that makes it handle "align" attribute for
> > headers, paragraphs and lists, works only when monospace font is used
> > (becoz of lame implementation of fill-paragraph). Also default value
> > of shr-use-fonts set to nil so monospace fonts are used by default.
>
> Seems reasonable overall, but I'm not sure if changing the default is
> justified.
And I'm sure it isn't. Not only do we not change past defaults so
easily, I personally don't think I'd like such a change, or consider
it correct.
> > + "Fill paragraph at or after point, breaking lines at positions matching regexp argument BRE-REGEXP.
The first line of the doc string should not be longer than 78
characters, and should be a complete sentence.
> > +BRE-REGEXP must be a regexp that determines positions where to break lines, default value is \\x2028."
> > + (unless bre-regexp (setq bre-regexp "\x2028"))
> > + (setq bre-regexp (concat bre-regexp "\\|\x2029"))
> > + (save-excursion
> > + (let ((line-begin) (paragraph-end))
> > + (forward-paragraph)
> > + (insert "\x2029") ; use \x2029 (unicode paragraph separator) to mark end of a paragraph
Why did you decide to use u+2028 and u+2029 for these purposes? Emacs
doesn't yet support these characters as Unicode intended, so using
them might have unexpected effects, and might produce different effect
if we start supporting them in the future.
This needs a NEWS entry, I think.
Thanks.
next prev parent reply other threads:[~2018-08-06 15:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 14:06 bug#32281: shr.el align support patch Bad Blue Bull
2018-08-06 2:52 ` Noam Postavsky
2018-08-06 15:13 ` Eli Zaretskii [this message]
2018-08-07 0:51 ` Bad Blue Bull
2018-08-07 0:59 ` Bad Blue Bull
2018-08-07 2:34 ` Noam Postavsky
2018-08-07 15:07 ` Eli Zaretskii
2018-08-07 16:54 ` Bad Blue Bull
2018-08-07 17:11 ` Bad Blue Bull
2018-08-07 17:19 ` Eli Zaretskii
2018-08-07 18:15 ` Bad Blue Bull
2018-08-07 18:15 ` Lars Ingebrigtsen
2018-08-07 19:56 ` Bad Blue Bull
2018-08-10 0:12 ` Noam Postavsky
2018-08-06 17:36 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bmafsf3l.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=32281@debbugs.gnu.org \
--cc=ibmbull@yandex.ru \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.