From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#34908: Push mark in xref-push-marker-stack Date: Wed, 20 Mar 2019 07:59:09 +0200 Message-ID: <83bm26t7bm.fsf@gnu.org> References: <87h8bz29ht.fsf@mail.linkov.net> <83h8bzv16k.fsf@gnu.org> <87a7hqio3h.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="84112"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 34908@debbugs.gnu.org, joaotavora@gmail.com, dgutov@yandex.ru To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 20 07:12:42 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h6USw-000Lku-55 for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Mar 2019 07:12:42 +0100 Original-Received: from localhost ([127.0.0.1]:43448 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h6USv-0001Ev-3A for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Mar 2019 02:12:41 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43911) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h6USi-0000zD-27 for bug-gnu-emacs@gnu.org; Wed, 20 Mar 2019 02:12:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h6UGg-0004YX-OW for bug-gnu-emacs@gnu.org; Wed, 20 Mar 2019 02:00:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37607) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h6UGg-0004XO-Ea for bug-gnu-emacs@gnu.org; Wed, 20 Mar 2019 02:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h6UGg-00044t-9y for bug-gnu-emacs@gnu.org; Wed, 20 Mar 2019 02:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Mar 2019 06:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34908 X-GNU-PR-Package: emacs Original-Received: via spool by 34908-submit@debbugs.gnu.org id=B34908.155306156515598 (code B ref 34908); Wed, 20 Mar 2019 06:00:02 +0000 Original-Received: (at 34908) by debbugs.gnu.org; 20 Mar 2019 05:59:25 +0000 Original-Received: from localhost ([127.0.0.1]:51151 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h6UG4-00043W-SF for submit@debbugs.gnu.org; Wed, 20 Mar 2019 01:59:25 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h6UG2-00043I-LH for 34908@debbugs.gnu.org; Wed, 20 Mar 2019 01:59:23 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50436) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h6UFw-0003ol-Hq; Wed, 20 Mar 2019 01:59:16 -0400 Original-Received: from [176.228.60.248] (port=2398 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h6UFu-00078C-0J; Wed, 20 Mar 2019 01:59:14 -0400 In-reply-to: <87a7hqio3h.fsf@mail.linkov.net> (message from Juri Linkov on Tue, 19 Mar 2019 22:59:18 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156533 Archived-At: > From: Juri Linkov > Cc: 34908@debbugs.gnu.org, joaotavora@gmail.com, dgutov@yandex.ru > Date: Tue, 19 Mar 2019 22:59:18 +0200 > > >> Shouldn't xref-push-marker-stack push the mark like all normal commands do? > > > > Fine with me to add that (I think etags.el-based M-. did this), but > > please make sure the manual and NEWS are updated with this > > information. > > I don't want to advertise this fix because the primary way to get back > for xref should be ‘M-,’. Well, it must be in NEWS, since this is a change in behavior. As for the manuals, it might be okay not to mention that, although I admit I don't understand your reasoning: something that is not a primary use doesn't automatically mean it shouldn't be documented. > Setting the mark is only needed for users who expect that every > significant change in position should leave a trace in the global > mark ring. I believe most of our commands that move to a far away position do set the mark.