From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35507: Gnus mojibakifies UTF-8 text/x-patch attachments from Thunderbird Date: Wed, 01 May 2019 20:33:31 +0300 Message-ID: <83bm0mqduc.fsf@gnu.org> References: <44a26585-7980-378c-9262-a567ddd3e617@cs.ucla.edu> <865zqv3tc2.fsf@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="251257"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35507@debbugs.gnu.org To: Andy Moreton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 01 19:36:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hLt9O-0013BO-LB for geb-bug-gnu-emacs@m.gmane.org; Wed, 01 May 2019 19:36:10 +0200 Original-Received: from localhost ([127.0.0.1]:37610 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLt9N-0003ze-Kn for geb-bug-gnu-emacs@m.gmane.org; Wed, 01 May 2019 13:36:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37564) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLt7Q-0002sg-Ts for bug-gnu-emacs@gnu.org; Wed, 01 May 2019 13:34:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLt7M-0001EB-F9 for bug-gnu-emacs@gnu.org; Wed, 01 May 2019 13:34:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59499) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hLt7K-0001CG-Jx for bug-gnu-emacs@gnu.org; Wed, 01 May 2019 13:34:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hLt7K-0002Ry-FO; Wed, 01 May 2019 13:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Wed, 01 May 2019 17:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35507 X-GNU-PR-Package: emacs,gnus Original-Received: via spool by 35507-submit@debbugs.gnu.org id=B35507.15567320409396 (code B ref 35507); Wed, 01 May 2019 17:34:02 +0000 Original-Received: (at 35507) by debbugs.gnu.org; 1 May 2019 17:34:00 +0000 Original-Received: from localhost ([127.0.0.1]:44808 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLt7I-0002RU-Em for submit@debbugs.gnu.org; Wed, 01 May 2019 13:34:00 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51353) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLt7G-0002RH-OG for 35507@debbugs.gnu.org; Wed, 01 May 2019 13:33:59 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56969) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLt7B-00011O-7W; Wed, 01 May 2019 13:33:53 -0400 Original-Received: from [176.228.60.248] (port=1230 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hLt75-00006P-B9; Wed, 01 May 2019 13:33:52 -0400 In-reply-to: <865zqv3tc2.fsf@gmail.com> (message from Andy Moreton on Wed, 01 May 2019 01:35:09 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158587 Archived-At: > From: Andy Moreton > Date: Wed, 01 May 2019 01:35:09 +0100 > > After a bit of experimenting, this minimal patch appears to fix things. > Should this also allow the user to choose the charset if none is > specified, or just hardwire it to utf-8 ? > > diff --git a/lisp/gnus/mm-decode.el b/lisp/gnus/mm-decode.el > index 3f255419e7..a99d52a7e7 100644 > --- a/lisp/gnus/mm-decode.el > +++ b/lisp/gnus/mm-decode.el > @@ -665,6 +665,9 @@ mm-dissect-buffer > (setq type (split-string (car ctl) "/")) > (setq subtype (cadr type) > type (car type)) > + ;; Fix missing charset in Thunderbird > + (unless (assq 'charset (cdr ctl)) > + (push '(charset . utf-8) (cdr ctl))) Please don't unconditionally force UTF-8 on users. At the very least this should be a user option, if at all.