From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36337: 26.1; XBM images are sometimes not displayed correctly Date: Fri, 28 Jun 2019 10:57:56 +0300 Message-ID: <83blyii1kr.fsf@gnu.org> References: <83tvcgml2s.fsf@gnu.org> <83o92omezr.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="211520"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36337@debbugs.gnu.org, triska@metalevel.at To: Pip Cet Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 28 09:59:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hglmp-000suL-Mu for geb-bug-gnu-emacs@m.gmane.org; Fri, 28 Jun 2019 09:59:11 +0200 Original-Received: from localhost ([::1]:57476 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hglmo-0003BQ-ML for geb-bug-gnu-emacs@m.gmane.org; Fri, 28 Jun 2019 03:59:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54709) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hglmi-0003B8-1h for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2019 03:59:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hglmg-0002Jx-Uj for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2019 03:59:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55002) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hglmg-0002Jf-R7 for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2019 03:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hglmg-0005Ma-KQ for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2019 03:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Jun 2019 07:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36337 X-GNU-PR-Package: emacs Original-Received: via spool by 36337-submit@debbugs.gnu.org id=B36337.156170870020561 (code B ref 36337); Fri, 28 Jun 2019 07:59:02 +0000 Original-Received: (at 36337) by debbugs.gnu.org; 28 Jun 2019 07:58:20 +0000 Original-Received: from localhost ([127.0.0.1]:40313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgllz-0005LX-J5 for submit@debbugs.gnu.org; Fri, 28 Jun 2019 03:58:19 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48715) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgllw-0005LD-RH for 36337@debbugs.gnu.org; Fri, 28 Jun 2019 03:58:18 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:38589) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hgllr-0001TG-0H; Fri, 28 Jun 2019 03:58:11 -0400 Original-Received: from [176.228.60.248] (port=4895 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hgllp-0003ZF-3E; Fri, 28 Jun 2019 03:58:09 -0400 In-reply-to: (message from Pip Cet on Sun, 23 Jun 2019 19:16:04 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161693 Archived-At: > From: Pip Cet > Date: Sun, 23 Jun 2019 19:16:04 +0000 > Cc: triska@metalevel.at, 36337@debbugs.gnu.org > > > Or maybe we should have a variant of make-bool-vector that accepts 2 > > dimension s instead of just one? > > I don't really see how that would be generally useful, to be honest. For one, it would be useful in this particular case. Or would you rather require the width of XBM be an integral multiple of 8? > In fact, I just played around with removing bool vector support > entirely. > > > > (However, do we want to encourage people to use bool vectors?) > > Why not? > > We seem to lack even very basic functions for interacting with bool > vectors, and hardly anyone appears to be using them. Even the :stipple > face property doesn't. Emacs starts up fine with bool vector support > removed. We can use vectors of nil/t (in most cases) or unibyte > strings or bignums (which have arbitrary size limits now, but > bigbignums would be just a few lines of code, I think). > > And people _think_ bool vectors have a natural presentation as bytes, > but they don't, because some people start with the most significant > bit. > > So I just don't see where bool vectors fit in. I'm sorry, but I object to removing a feature that has been with us since Emacs 19, for which we installed new operations just recently in Emacs 24. Emacs is too stable a program to remove such basic features because we cannot immediately see where they fit in. Please consider them as "fitting in" by definition; we can only remove them if there are very good _positive_ reasons for removal, not because we cannot find reasons _not_ to remove them. > > Evidently, it's convenient in this particular use case. > > Is the convenience worth a thousand lines of code (much of it C) and > documentation? Not necessarily; it might mean that the proposed solution is not the best one. What you propose is not what I think I had in mind. I meant to extend make-bool-vector (or make a new function, if extending proves inconvenient or inelegant) that generates a bool-vector given 2 dimensions, not one. Then such vectors could be used to create XBM images of arbitrary dimensions. We could even call this new function something like make-xbm-data or somesuch, if its utility is limited to XBM images. Thanks.