From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36452: [PATCH] Add tests for bookmark.el Date: Wed, 03 Jul 2019 09:59:54 +0300 Message-ID: <83blybd2mt.fsf@gnu.org> References: <83zhlwcrtv.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="102261"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36452@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 03 09:01:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hiZGX-000QSA-KN for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Jul 2019 09:01:17 +0200 Original-Received: from localhost ([::1]:33218 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiZGW-0006o5-Ml for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Jul 2019 03:01:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55883) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiZGR-0006nw-Ja for bug-gnu-emacs@gnu.org; Wed, 03 Jul 2019 03:01:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hiZGO-00031c-Ne for bug-gnu-emacs@gnu.org; Wed, 03 Jul 2019 03:01:11 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39528) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hiZGH-0002x1-Po for bug-gnu-emacs@gnu.org; Wed, 03 Jul 2019 03:01:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hiZGH-0002Iq-K5 for bug-gnu-emacs@gnu.org; Wed, 03 Jul 2019 03:01:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Jul 2019 07:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36452 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36452-submit@debbugs.gnu.org id=B36452.15621372198778 (code B ref 36452); Wed, 03 Jul 2019 07:01:01 +0000 Original-Received: (at 36452) by debbugs.gnu.org; 3 Jul 2019 07:00:19 +0000 Original-Received: from localhost ([127.0.0.1]:48344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiZFb-0002HV-6Y for submit@debbugs.gnu.org; Wed, 03 Jul 2019 03:00:19 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43420) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiZFa-0002HG-77 for 36452@debbugs.gnu.org; Wed, 03 Jul 2019 03:00:18 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35234) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hiZFU-0002Ky-Kj; Wed, 03 Jul 2019 03:00:12 -0400 Original-Received: from [176.228.60.248] (port=1587 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hiZFO-0001H7-Te; Wed, 03 Jul 2019 03:00:10 -0400 In-reply-to: (message from Stefan Kangas on Wed, 3 Jul 2019 08:33:22 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162012 Archived-At: > From: Stefan Kangas > Date: Wed, 3 Jul 2019 08:33:22 +0200 > Cc: 36452@debbugs.gnu.org > > > One particular aspect of the bookmarks that I'd like to see tested is > > non-ASCII bookmark names and annotations. The code includes some > > slightly involved logic for determining how to encode the info on > > disk, so I wonder how well does that work in practice. > > OK. I added tests for that in the attached patch using strings > manually copied from HELLO. It works just fine to save and then load > bookmarks for the set of languages I chose to include characters from. > That is, we have the same before bookmark-save as we get after > bookmark-load. Thanks. Please add to that text something that doesn't yield valid UTF-8 byte sequence. For example, these two strings: (decode-coding-string "\xE3\x32\x9A\x36" 'chinese-gb18030) (char-to-string (decode-char 'eight-bit #x81)) (Please include these snippets directly, not their result as a literal string, to make sure the unusual characters survive intact.)