From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: 36452@debbugs.gnu.org
Subject: bug#36452: [PATCH] Add tests for bookmark.el
Date: Wed, 03 Jul 2019 09:59:54 +0300 [thread overview]
Message-ID: <83blybd2mt.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmn23ggnKF5M8EL1gPueKkVj0T30q6JmcaUFfcL0SpqUiw@mail.gmail.com> (message from Stefan Kangas on Wed, 3 Jul 2019 08:33:22 +0200)
> From: Stefan Kangas <stefan@marxist.se>
> Date: Wed, 3 Jul 2019 08:33:22 +0200
> Cc: 36452@debbugs.gnu.org
>
> > One particular aspect of the bookmarks that I'd like to see tested is
> > non-ASCII bookmark names and annotations. The code includes some
> > slightly involved logic for determining how to encode the info on
> > disk, so I wonder how well does that work in practice.
>
> OK. I added tests for that in the attached patch using strings
> manually copied from HELLO. It works just fine to save and then load
> bookmarks for the set of languages I chose to include characters from.
> That is, we have the same before bookmark-save as we get after
> bookmark-load.
Thanks. Please add to that text something that doesn't yield valid
UTF-8 byte sequence. For example, these two strings:
(decode-coding-string "\xE3\x32\x9A\x36" 'chinese-gb18030)
(char-to-string (decode-char 'eight-bit #x81))
(Please include these snippets directly, not their result as a literal
string, to make sure the unusual characters survive intact.)
next prev parent reply other threads:[~2019-07-03 6:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-30 23:32 bug#36452: [PATCH] Add tests for bookmark.el Stefan Kangas
2019-07-02 16:41 ` Eli Zaretskii
2019-07-03 6:33 ` Stefan Kangas
2019-07-03 6:59 ` Eli Zaretskii [this message]
2019-07-03 11:01 ` Stefan Kangas
2019-07-03 11:24 ` Eli Zaretskii
2019-07-03 11:42 ` Stefan Kangas
2019-07-03 11:53 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83blybd2mt.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=36452@debbugs.gnu.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.