From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36780: 26.1; request: savehist should also save log-edit-comment-ring by default Date: Fri, 23 Aug 2019 11:57:53 +0300 Message-ID: <83blwgb6ni.fsf@gnu.org> References: <87blwgforq.fsf@gnus.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="144614"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacsuser@freemail.hu, 36780@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 23 10:58:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i15Od-000bR0-R8 for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Aug 2019 10:58:11 +0200 Original-Received: from localhost ([::1]:53000 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i15Oc-0005JJ-8X for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Aug 2019 04:58:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48158) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i15OV-0005JC-Cw for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2019 04:58:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i15OU-0005x2-Fr for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2019 04:58:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58546) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i15OU-0005wq-CH for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2019 04:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i15OU-0002oa-7d for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2019 04:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Aug 2019 08:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36780 X-GNU-PR-Package: emacs Original-Received: via spool by 36780-submit@debbugs.gnu.org id=B36780.156655067310806 (code B ref 36780); Fri, 23 Aug 2019 08:58:02 +0000 Original-Received: (at 36780) by debbugs.gnu.org; 23 Aug 2019 08:57:53 +0000 Original-Received: from localhost ([127.0.0.1]:39134 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i15OL-0002oE-Hw for submit@debbugs.gnu.org; Fri, 23 Aug 2019 04:57:53 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i15OK-0002nz-3n for 36780@debbugs.gnu.org; Fri, 23 Aug 2019 04:57:52 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55425) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i15OE-0005rP-E0; Fri, 23 Aug 2019 04:57:46 -0400 Original-Received: from [176.228.60.248] (port=2759 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1i15OC-0006YQ-8x; Fri, 23 Aug 2019 04:57:45 -0400 In-reply-to: <87blwgforq.fsf@gnus.org> (message from Lars Ingebrigtsen on Fri, 23 Aug 2019 07:12:57 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165678 Archived-At: > From: Lars Ingebrigtsen > Date: Fri, 23 Aug 2019 07:12:57 +0200 > Cc: 36780@debbugs.gnu.org > > > I recommend adding > > > > (add-to-list 'savehist-additional-variables 'log-edit-comment-ring) > > > > to log-edit.el, so if savehist is enabled then it is saved as well. > > `savehist-additional-variables' is explicitly reserved for users to add > stuff to, so I don't think it'd be appropriate for log-edit.el to add > anything to it. > > But we could add a new variable, say `savehist-variables', that as a > default value could be > > (log-edit-comment-ring) > > and anything else the Emacs maintainers think could be saved by default. > > Opinions? I don't see why the solution of customizing savehist-additional-variables by the user is not the right one. After all, we are not talking about minibuffer history here. The savehist package defines itself as being for "saving the minibuffer history". What you suggest makes it a much more general facility, and we then would need to review many other variables and decide whether they are candidates for saving (some of them are already saved by separate features). Maybe we should do that, but that's a much broader issue than this particular bug report.