From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37236: 25.1; dired fails on pCloud drive Date: Fri, 30 Aug 2019 18:20:48 +0300 Message-ID: <83blw6addb.fsf@gnu.org> References: <8EC3EC77-26FE-4AC8-9A7D-0F56A09935C6@zepherin.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="122878"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37236@debbugs.gnu.org To: Damon Permezel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 30 17:30:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i3iqu-000Vry-PF for geb-bug-gnu-emacs@m.gmane.org; Fri, 30 Aug 2019 17:30:16 +0200 Original-Received: from localhost ([::1]:33724 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i3iqt-0004iE-Kw for geb-bug-gnu-emacs@m.gmane.org; Fri, 30 Aug 2019 11:30:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45489) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i3ii3-0002Ma-6y for bug-gnu-emacs@gnu.org; Fri, 30 Aug 2019 11:21:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i3ihz-0006ZJ-1u for bug-gnu-emacs@gnu.org; Fri, 30 Aug 2019 11:21:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45928) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i3ihy-0006Yk-UZ for bug-gnu-emacs@gnu.org; Fri, 30 Aug 2019 11:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i3ihx-0007K3-Ow for bug-gnu-emacs@gnu.org; Fri, 30 Aug 2019 11:21:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Aug 2019 15:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37236 X-GNU-PR-Package: emacs Original-Received: via spool by 37236-submit@debbugs.gnu.org id=B37236.156717845028109 (code B ref 37236); Fri, 30 Aug 2019 15:21:01 +0000 Original-Received: (at 37236) by debbugs.gnu.org; 30 Aug 2019 15:20:50 +0000 Original-Received: from localhost ([127.0.0.1]:54749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i3ihm-0007JJ-3X for submit@debbugs.gnu.org; Fri, 30 Aug 2019 11:20:50 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36129) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i3ihj-0007J6-Qc for 37236@debbugs.gnu.org; Fri, 30 Aug 2019 11:20:48 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43755) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i3ihc-0005PJ-Dj; Fri, 30 Aug 2019 11:20:40 -0400 Original-Received: from [176.228.60.248] (port=3843 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1i3ihb-000671-Jw; Fri, 30 Aug 2019 11:20:40 -0400 In-reply-to: <8EC3EC77-26FE-4AC8-9A7D-0F56A09935C6@zepherin.com> (message from Damon Permezel on Fri, 30 Aug 2019 18:14:03 +1000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166099 Archived-At: > From: Damon Permezel > Date: Fri, 30 Aug 2019 18:14:03 +1000 > > M-x dired ~/pCloud\ Drive > > Debugger entered--Lisp error: (wrong-type-argument consp nil) > ls-lisp-sanitize(((".VolumeIcon.icns" nil 1 "dap" "wheel" (23900 56314 0 0) (23900 56314 0 0) (23900 56314 0 0) 1708546 "-r--r--r--" t 53210 855638019) (".DS_Store" nil 1 "dap" "staff" (23911 33443 0 0) (23911 33443 0 0) (23911 33443 0 0) 8196 "-rw-r--r--" t 53136 855638019) ("Getting started with pCloud.pdf" nil 1 "dap" "staff" (23894 11575 0 0) (23894 11575 0 0) (23894 11575 0 0) 22442353 "-rw-r--r--" t 53209 855638019) ("Public Folder" t 2 "dap" "staff" (23911 34577 0 0) (23911 34577 0 0) (23911 34577 0 0) 4096 "drwxr-xr-x" t 53208 855638019) ("Crypto Folder" t 3 "dap" "staff" (23912 55020 0 0) (23912 55020 0 0) (23912 55020 0 0) 4096 "drwxr-xr-x" t 53112 855638019) ("CryptoMator" t 3 "dap" "staff" (23899 61629 0 0) (23899 61629 0 0) (23899 61629 0 0) 4096 "drwxr-xr-x" t 53107 85563 8019) ("rclone" t 5 "dap" "staff" (23894 12721 0 0) (23894 12721 0 0) (23894 12721 0 0) 4096 "drwxr-xr-x" t 308 855638019) ("My Videos" t 2 "dap" "staff" (23894 11575 0 0) (23894 11575 0 0) (23894 11575 0 0) 4096 "drwxr-xr-x" t 53207 855638019) ("My Pictures" t 2 "dap" "staff" (23894 11575 0 0) (23894 11575 0 0) (23894 11575 0 0) 4096 "drwxr-xr-x" t 53206 855638019) ("My Music" t 2 "dap" "staff" (23894 11575 0 0) (23894 11575 0 0) (23894 11575 0 0) 4096 "drwxr-xr-x" t 53205 855638019) ("." t 9 "dap" "staff" (23911 34577 0 0) (23911 34577 0 0) (23911 34577 0 0) 4096 "drwxr-xr-x" t 1 855638019))) > ls-lisp-insert-directory("/Users/dap/pCloud Drive/" (97 108) nil nil t) > ls-lisp--insert-directory(#[... ls-lisp isn't prepared for a situation where a directory has a "." entry, but doesn't have a ".." entry. Does the patch below fix the problem? diff --git a/lisp/ls-lisp.el b/lisp/ls-lisp.el index e802c24..8491181 100644 --- a/lisp/ls-lisp.el +++ b/lisp/ls-lisp.el @@ -517,7 +517,8 @@ ls-lisp-sanitize are copied from the \".\" entry, if they are non-nil. Otherwise, the offending element is removed from the list, as are any elements for other directory entries with nil attributes." - (if (and (null (cdr (assoc ".." file-alist))) + (if (and (consp (assoc ".." file-alist)) + (null (cdr (assoc ".." file-alist))) (cdr (assoc "." file-alist))) (setcdr (assoc ".." file-alist) (cdr (assoc "." file-alist)))) (rassq-delete-all nil file-alist))