From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37393: 26.2.90; [PATCH] Speed up 'csv-align-fields' Date: Sun, 15 Sep 2019 19:17:49 +0300 Message-ID: <83blvly1n6.fsf@gnu.org> References: <5d7a7b56.1c69fb81.c32f6.840d@mx.google.com> <5d7e5f00.1c69fb81.43f55.3fa2@mx.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="250379"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37393@debbugs.gnu.org, monnier@iro.umontreal.ca, sdl.web@gmail.com To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 15 18:18:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i9XE3-0012zW-IT for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Sep 2019 18:18:11 +0200 Original-Received: from localhost ([::1]:56006 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9XE2-0006TL-22 for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Sep 2019 12:18:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52082) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9XDv-0006Rf-3t for bug-gnu-emacs@gnu.org; Sun, 15 Sep 2019 12:18:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i9XDu-0000Ch-9R for bug-gnu-emacs@gnu.org; Sun, 15 Sep 2019 12:18:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39850) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i9XDu-0000Cc-6b for bug-gnu-emacs@gnu.org; Sun, 15 Sep 2019 12:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i9XDu-0005U4-01 for bug-gnu-emacs@gnu.org; Sun, 15 Sep 2019 12:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Sep 2019 16:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37393 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37393-submit@debbugs.gnu.org id=B37393.156856425921045 (code B ref 37393); Sun, 15 Sep 2019 16:18:01 +0000 Original-Received: (at 37393) by debbugs.gnu.org; 15 Sep 2019 16:17:39 +0000 Original-Received: from localhost ([127.0.0.1]:48671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i9XDW-0005TN-PH for submit@debbugs.gnu.org; Sun, 15 Sep 2019 12:17:39 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43567) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i9XDU-0005T6-Te for 37393@debbugs.gnu.org; Sun, 15 Sep 2019 12:17:37 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37563) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i9XDP-0008Ea-H1; Sun, 15 Sep 2019 12:17:31 -0400 Original-Received: from [176.228.60.248] (port=1144 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1i9XDO-0000Ww-6L; Sun, 15 Sep 2019 12:17:30 -0400 In-reply-to: <5d7e5f00.1c69fb81.43f55.3fa2@mx.google.com> (message from Simen =?UTF-8?Q?Heggest=C3=B8yl?= on Sun, 15 Sep 2019 17:55:44 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166512 Archived-At: > From: Simen Heggestøyl > Date: Sun, 15 Sep 2019 17:55:44 +0200 > Cc: 37393@debbugs.gnu.org, sdl.web@gmail.com > > > If you're interested in this line, I think there are two avenues to > > improve the behavior further: > > - align lazily via jit-lock (this way the time is determined by the > > amount of text displayed rather than the total file size). > > Wouldn't that still depend on knowing the column widths? I find that the > column width computation is taking about 80% of the time when calling > 'csv-align-fields' (after the patch). I'm talking here about something I don't understand well enough, but did you try computing column width using vertical-motion?