From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Question about display engine Date: Tue, 17 Sep 2019 12:48:02 +0300 Message-ID: <83blvjw8x9.fsf@gnu.org> References: <20190906093117.25qfim4kcrmiqunk@Ergus> <83o8zw5zh8.fsf@gnu.org> <83mufg5yn1.fsf@gnu.org> <20190908005109.s7hhcczkrcbzewdc@Ergus> <83imq24qx3.fsf@gnu.org> <20190908182346.hheaveun2pw5usb6@Ergus> <20190914204207.gfyvgbb7t4ztya7a@Ergus> <83ftkxy3r7.fsf@gnu.org> <20190915214233.xkjtoxyfxkyrd2id@Ergus> <20190917021725.xxhhhxcz3nr6sb7z@Ergus> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="239043"; mail-complaints-to="usenet@blaine.gmane.org" Cc: rudalics@gmx.at, emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 17 11:48:41 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iAA6D-00100k-2N for ged-emacs-devel@m.gmane.org; Tue, 17 Sep 2019 11:48:41 +0200 Original-Received: from localhost ([::1]:43384 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iAA6B-0005vU-W7 for ged-emacs-devel@m.gmane.org; Tue, 17 Sep 2019 05:48:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38432) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iAA5d-0005vO-47 for emacs-devel@gnu.org; Tue, 17 Sep 2019 05:48:06 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:38167) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iAA5c-0004cc-Rt; Tue, 17 Sep 2019 05:48:04 -0400 Original-Received: from [176.228.60.248] (port=2391 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iAA5b-0002nR-1h; Tue, 17 Sep 2019 05:48:03 -0400 In-reply-to: <20190917021725.xxhhhxcz3nr6sb7z@Ergus> (message from Ergus on Tue, 17 Sep 2019 04:17:26 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240101 Archived-At: > Date: Tue, 17 Sep 2019 04:17:26 +0200 > From: Ergus > Cc: rudalics@gmx.at, emacs-devel@gnu.org > > >>>>The filter now in merge_ref only works when !CONSP(ref_name). As it only > >>>>bypass the extra parameter to merge_named... it this right in the > >>>>general case? > >> > >>I think we should support all the cases, otherwise the feature will > >>behave inconsistently, and we will get bug reports. > >> > >About this; the problem is that in the general case I'm not sure what's > >the "right" behavior for the other cases. When !CONSP(ref_name) it means > >that the parameter is a face_name; but in the other cases it means that > >we are explicitly specifying the attributes as a cons list or as > >:atribute value pairs... What's expected to happen in those cases?? > > > Hi: > Any Idea about this? Could you suggest what to do when CONSP(ref_name) > is true? I will reply to this soon, too swamped now. > >>>Could you suggest (if any) if there are some conditions we can use to > >>>avoid the call to handle_face_prop_general in some cases? > >> > >>Why, did you see any tangible slow-down of redisplay due to these > >>changes? > > > No actually, but I think that there should be many cases where we could > avoid calling the new function. So it is better to put them and avoid > unneeded calls. > > For example when face_id is the default_face_id maybe? Yes, for the default face ID it might be a good idea to add some optimization, as that will be the most frequent case. But beware of remapped default face, though.