From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#20153: 24.4.91; destructive add-face-text-property and string deep copying Date: Wed, 09 Oct 2019 20:10:16 +0300 Message-ID: <83blupvo93.fsf@gnu.org> References: <87bnjnyhtb.fsf@gmail.com> <874l0iwrfg.fsf@gnus.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="252987"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 20153@debbugs.gnu.org, ohwoeowho@gmail.com To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 09 22:15:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iIIMY-0013g5-Bn for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Oct 2019 22:15:10 +0200 Original-Received: from localhost ([::1]:56670 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIIMW-0006km-Im for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Oct 2019 16:15:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60559) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIFUP-0006vi-9Y for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 13:11:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIFUO-0007lY-DU for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 13:11:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45177) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iIFUM-0007k6-81 for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 13:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iIFUM-0002fc-0m for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 13:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Oct 2019 17:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20153 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 20153-submit@debbugs.gnu.org id=B20153.157064105210236 (code B ref 20153); Wed, 09 Oct 2019 17:11:01 +0000 Original-Received: (at 20153) by debbugs.gnu.org; 9 Oct 2019 17:10:52 +0000 Original-Received: from localhost ([127.0.0.1]:53993 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIFUB-0002f2-Ql for submit@debbugs.gnu.org; Wed, 09 Oct 2019 13:10:52 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51407) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIFUA-0002em-2B for 20153@debbugs.gnu.org; Wed, 09 Oct 2019 13:10:50 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44609) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iIFU4-0007dV-PU; Wed, 09 Oct 2019 13:10:44 -0400 Original-Received: from [176.228.60.248] (port=2710 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iIFU2-0002TS-7R; Wed, 09 Oct 2019 13:10:43 -0400 In-reply-to: <874l0iwrfg.fsf@gnus.org> (message from Lars Ingebrigtsen on Wed, 09 Oct 2019 05:04:03 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168767 Archived-At: > From: Lars Ingebrigtsen > Date: Wed, 09 Oct 2019 05:04:03 +0200 > Cc: 20153@debbugs.gnu.org > > Instead I've now changed add_properties (and add_text_properties_1) to > take a bool parameter to say whether they're allowed to be destructive > or not, and make the add-face-text-property call that with false as the > parameter if the object is a string. This fixes the test case for me > and should hopefully have no measurable performance impact. Isn't that a backward-incompatible change?