* Please install this and ack
@ 2019-10-27 2:02 Richard Stallman
2019-11-01 9:47 ` Eli Zaretskii
0 siblings, 1 reply; 2+ messages in thread
From: Richard Stallman @ 2019-10-27 2:02 UTC (permalink / raw)
To: emacs-devel
[[[ To any NSA and FBI agents reading my email: please consider ]]]
[[[ whether defending the US Constitution against all enemies, ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]
Would someone please install this for me?
diff --git a/doc/lispref/functions.texi b/doc/lispref/functions.texi
index d082225..fe1dfa5 100644
--- a/doc/lispref/functions.texi
+++ b/doc/lispref/functions.texi
@@ -1811,9 +1811,15 @@ Advising Named Functions
(@pxref{Hooks}). If you simply want to change what a particular key
does, it may be better to write a new command, and remap the old
command's key bindings to the new one (@pxref{Remapping Commands}).
-In particular, Emacs's own source files should not put advice on
-functions in Emacs. (There are currently a few exceptions to this
-convention, but we aim to correct them.)
+
+ If you are writing code for release, for others to use, try to avoid
+including advice in it. If the function you want to advise has no
+hook to do the job, please talk with the Emacs developers about adding
+a suitable hook. Especially, Emacs's own source files should not put
+advice on functions in Emacs. (There are currently a few exceptions
+to this convention, but we aim to correct them.) It is generally
+cleaner to create a new hook in @code{foo}, and make @code{bar} use
+the hook, than to have @code{bar} put advice in @code{foo}.
Special forms (@pxref{Special Forms}) cannot be advised, however macros can
be advised, in much the same way as functions. Of course, this will not affect
--
Dr Richard Stallman
Founder, Free Software Foundation (https://gnu.org, https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: Please install this and ack
2019-10-27 2:02 Please install this and ack Richard Stallman
@ 2019-11-01 9:47 ` Eli Zaretskii
0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2019-11-01 9:47 UTC (permalink / raw)
To: rms; +Cc: emacs-devel
> From: Richard Stallman <rms@gnu.org>
> Date: Sat, 26 Oct 2019 22:02:57 -0400
>
> Would someone please install this for me?
Done.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-01 9:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-27 2:02 Please install this and ack Richard Stallman
2019-11-01 9:47 ` Eli Zaretskii
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.