From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#38791: 27.0.60; Multiline mini-window fails to resize after clearing message Date: Mon, 30 Dec 2019 17:56:07 +0200 Message-ID: <83blrpn6y0.fsf@gnu.org> References: <838smvnr5o.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="106082"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 38791-done@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 30 16:57:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ilxPq-000RSn-B2 for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Dec 2019 16:57:10 +0100 Original-Received: from localhost ([::1]:34260 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ilxPp-0000gz-6z for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Dec 2019 10:57:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46379) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ilxPj-0000gl-Db for bug-gnu-emacs@gnu.org; Mon, 30 Dec 2019 10:57:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ilxPi-0002YQ-DO for bug-gnu-emacs@gnu.org; Mon, 30 Dec 2019 10:57:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55518) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ilxPi-0002YH-A0 for bug-gnu-emacs@gnu.org; Mon, 30 Dec 2019 10:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ilxPi-0003l9-AP for bug-gnu-emacs@gnu.org; Mon, 30 Dec 2019 10:57:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Dec 2019 15:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 38791 X-GNU-PR-Package: emacs Mail-Followup-To: 38791@debbugs.gnu.org, eliz@gnu.org, eliz@gnu.org Original-Received: via spool by 38791-done@debbugs.gnu.org id=D38791.157772136914376 (code D ref 38791); Mon, 30 Dec 2019 15:57:02 +0000 Original-Received: (at 38791-done) by debbugs.gnu.org; 30 Dec 2019 15:56:09 +0000 Original-Received: from localhost ([127.0.0.1]:33257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilxOq-0003jo-Rv for submit@debbugs.gnu.org; Mon, 30 Dec 2019 10:56:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37279) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilxOo-0003jN-W2 for 38791-done@debbugs.gnu.org; Mon, 30 Dec 2019 10:56:07 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36164) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ilxOj-0002Hd-Gp; Mon, 30 Dec 2019 10:56:01 -0500 Original-Received: from [176.228.60.248] (port=2017 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ilxOh-0007zh-Tp; Mon, 30 Dec 2019 10:56:01 -0500 In-reply-to: (message from martin rudalics on Sun, 29 Dec 2019 19:33:52 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173938 Archived-At: > From: martin rudalics > Date: Sun, 29 Dec 2019 19:33:52 +0100 > > > This is a regression, because in Emacs 26 this works as expected. > > > > The patch to fix this is below. It reverts a small part of commit > > 8e0ebb9, which inadvertently changed the logic in grow_mini_window. > > The problem in this case was that old_height + delta evaluated to > > zero, but instead of limiting the result to the equivalent of 1 line, > > the code did nothing. > > It apparently never entered my mind that WINDOW_BOX_TEXT_HEIGHT might > mean something different from the height of that window's buffer text. > Shameful. Well, the name is ambiguous. I installed the fix, and I'm closing the bug report.