From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: 38791-done@debbugs.gnu.org
Subject: bug#38791: 27.0.60; Multiline mini-window fails to resize after clearing message
Date: Mon, 30 Dec 2019 17:56:07 +0200 [thread overview]
Message-ID: <83blrpn6y0.fsf@gnu.org> (raw)
In-Reply-To: <a4a025cf-e03e-5317-e11e-5c6407585483@gmx.at> (message from martin rudalics on Sun, 29 Dec 2019 19:33:52 +0100)
> From: martin rudalics <rudalics@gmx.at>
> Date: Sun, 29 Dec 2019 19:33:52 +0100
>
> > This is a regression, because in Emacs 26 this works as expected.
> >
> > The patch to fix this is below. It reverts a small part of commit
> > 8e0ebb9, which inadvertently changed the logic in grow_mini_window.
> > The problem in this case was that old_height + delta evaluated to
> > zero, but instead of limiting the result to the equivalent of 1 line,
> > the code did nothing.
>
> It apparently never entered my mind that WINDOW_BOX_TEXT_HEIGHT might
> mean something different from the height of that window's buffer text.
> Shameful.
Well, the name is ambiguous.
I installed the fix, and I'm closing the bug report.
next prev parent reply other threads:[~2019-12-30 15:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-29 14:27 bug#38791: 27.0.60; Multiline mini-window fails to resize after clearing message Eli Zaretskii
2019-12-29 18:33 ` martin rudalics
2019-12-30 15:56 ` Eli Zaretskii [this message]
2019-12-30 17:54 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83blrpn6y0.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=38791-done@debbugs.gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.