From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: etags.c:88:0: warning: "NDEBUG" redefined
Date: Sat, 21 Mar 2020 10:19:51 +0200
Message-ID: <83bloqdsrc.fsf@gnu.org>
References: <CAH8yC8k5ANxkgcc11gufcZXOqqMRTZY6deOwydCTeO+hzyB6Kw@mail.gmail.com>
Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202";
	logging-data="33442"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org
To: noloader@gmail.com
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 21 09:20:36 2020
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1jFZMx-0008bZ-C9
	for ged-emacs-devel@m.gmane-mx.org; Sat, 21 Mar 2020 09:20:35 +0100
Original-Received: from localhost ([::1]:34252 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1jFZMw-0004Qh-EB
	for ged-emacs-devel@m.gmane-mx.org; Sat, 21 Mar 2020 04:20:34 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43344)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>) id 1jFZMG-0003ww-JH
 for emacs-devel@gnu.org; Sat, 21 Mar 2020 04:19:53 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42250)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
 id 1jFZMG-0006ED-FO; Sat, 21 Mar 2020 04:19:52 -0400
Original-Received: from [176.228.60.248] (port=4384 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1jFZMF-0004Pb-KE; Sat, 21 Mar 2020 04:19:52 -0400
In-Reply-To: <CAH8yC8k5ANxkgcc11gufcZXOqqMRTZY6deOwydCTeO+hzyB6Kw@mail.gmail.com>
 (message from Jeffrey Walton on Sat, 21 Mar 2020 02:15:18 -0400)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:245626
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/245626>

> From: Jeffrey Walton <noloader@gmail.com>
> Date: Sat, 21 Mar 2020 02:15:18 -0400
> 
> I keep -DNDEBUG defined in CPPFLAGS in my environment. When I build
> emacs I see some extra noise because of it:
> 
> gcc     -I. -I../src -I../lib -I. -I./../src -I./../lib  -L/tmp/ok_to_delete/lib
>  -Wl,-R,/../lib -Wl,-R,/tmp/ok_to_delete/lib -Wl,--enable-new-dtags -I/tmp/ok_to
> _delete/include -DNDEBUG -g2 -O2 -march=native -fPIC -pthread -DEMACS_NAME="\"GN
> U Emacs\"" -DVERSION="\"26.3\"" -o etags etags.c regex.o  ../lib/libgnu.a
> etags.c:88:0: warning: "NDEBUG" redefined
>  #  define NDEBUG  /* disable assert */
>  <command-line>:0:0: note: this is the location of the previous definition
> ...
> 
> Would it be possible to guard your use of NDEBUG?

The current etags.c in the Emacs repository no longer uses NDEBUG, so
this issue was already solved.

Thanks.