From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: policy regarding DEFUNs in subr-x.el
Date: Sun, 22 Mar 2020 19:12:43 +0200
Message-ID: <83bloocnzo.fsf@gnu.org>
References: <87d0945r4z.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202";
	logging-data="7285"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org
To: =?utf-8?B?xaB0xJtww6FuIE7Em21lYw==?= <stepnem@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Mar 22 18:13:32 2020
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1jG4AG-0001mr-1C
	for ged-emacs-devel@m.gmane-mx.org; Sun, 22 Mar 2020 18:13:32 +0100
Original-Received: from localhost ([::1]:48347 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1jG4AF-000493-49
	for ged-emacs-devel@m.gmane-mx.org; Sun, 22 Mar 2020 13:13:31 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50021)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>) id 1jG49T-0003bm-BL
 for emacs-devel@gnu.org; Sun, 22 Mar 2020 13:12:44 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37151)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
 id 1jG49T-0002Ak-6J; Sun, 22 Mar 2020 13:12:43 -0400
Original-Received: from [176.228.60.248] (port=2398 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1jG49S-0000QH-9P; Sun, 22 Mar 2020 13:12:42 -0400
In-Reply-To: <87d0945r4z.fsf@gmail.com> (message from =?utf-8?B?xaB0xJtw?=
 =?utf-8?B?w6FuIE7Em21lYw==?= on Sun, 22 Mar 2020 16:46:36 +0100)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:245680
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/245680>

> From: Štěpán Němec <stepnem@gmail.com>
> Date: Sun, 22 Mar 2020 16:46:36 +0100
> 
> Now, it does seem sensible for the function to be a normal, not inline,
> function, but what about the commentary and all the other defsubsts,
> including the other string utilities?
> 
> If the no-defun policy should be changed, or if I was mistaken in
> believing there was one to begin with, shouldn't the commentary
> recommending compile-time usage be removed, and at least some of the
> other defsubsts turned into defuns, too?

I don't see that the commentary says the code in this file must be
inline.  If something in the wording implies that, let's change the
wording so that it doesn't.

>From my POV, there's no reason to require that everything in that file
is inlined, and that single "outlier" is the evidence.