From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Emacs 27 face :extend attribute not working with pulse.el? Date: Thu, 09 Apr 2020 19:46:26 +0300 Message-ID: <83blo0obdp.fsf@gnu.org> References: <875ze8iza9.fsf@alphapapa.net> <87y2r4hk58.fsf@alphapapa.net> <83lfn4ojhc.fsf@gnu.org> <87tv1shg33.fsf@alphapapa.net> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="88216"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Adam Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Apr 09 18:48:24 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jMaLl-000MoG-Kd for ged-emacs-devel@m.gmane-mx.org; Thu, 09 Apr 2020 18:48:21 +0200 Original-Received: from localhost ([::1]:52704 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jMaLk-0002Ha-Ld for ged-emacs-devel@m.gmane-mx.org; Thu, 09 Apr 2020 12:48:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58831) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jMaKH-0001PF-72 for emacs-devel@gnu.org; Thu, 09 Apr 2020 12:46:50 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50334) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jMaKE-0002pS-La; Thu, 09 Apr 2020 12:46:48 -0400 Original-Received: from [176.228.60.248] (port=3506 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jMaKD-0007yM-OR; Thu, 09 Apr 2020 12:46:46 -0400 In-Reply-To: <87tv1shg33.fsf@alphapapa.net> (message from Adam Porter on Thu, 09 Apr 2020 09:46:40 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:246718 Archived-At: > From: Adam Porter > Date: Thu, 09 Apr 2020 09:46:40 -0500 > > >> This seems like an obvious, easy fix to restore the previous behavior, > >> but I don't know if it's the "correct" one, because it appears to have > >> the side effect of forcing extension even when > >> pulse-momentary-highlight-one-line is called with a face argument which > >> does not have ":extend t" set. > > > > Does the patch below produce good results? > > > > diff --git a/lisp/cedet/pulse.el b/lisp/cedet/pulse.el > > index 16243e1..8649254 100644 > > --- a/lisp/cedet/pulse.el > > +++ b/lisp/cedet/pulse.el > > @@ -161,6 +161,9 @@ pulse-reset-face > > (face-background face nil t) > > (face-background 'pulse-highlight-start-face) > > )) > > + (and face > > + (set-face-extend 'pulse-highlight-face > > + (face-extend-p face nil t))) > > (put 'pulse-highlight-face :startface (or face > > 'pulse-highlight-start-face)) > > (put 'pulse-highlight-face :iteration 0)) > > Yes, it seems to behave as expected. Thanks. Thanks, installed on the emacs-27 branch.