From: Eli Zaretskii <eliz@gnu.org>
To: Adam Porter <adam@alphapapa.net>
Cc: emacs-devel@gnu.org
Subject: Re: Emacs 27 face :extend attribute not working with pulse.el?
Date: Thu, 09 Apr 2020 19:46:26 +0300 [thread overview]
Message-ID: <83blo0obdp.fsf@gnu.org> (raw)
In-Reply-To: <87tv1shg33.fsf@alphapapa.net> (message from Adam Porter on Thu, 09 Apr 2020 09:46:40 -0500)
> From: Adam Porter <adam@alphapapa.net>
> Date: Thu, 09 Apr 2020 09:46:40 -0500
>
> >> This seems like an obvious, easy fix to restore the previous behavior,
> >> but I don't know if it's the "correct" one, because it appears to have
> >> the side effect of forcing extension even when
> >> pulse-momentary-highlight-one-line is called with a face argument which
> >> does not have ":extend t" set.
> >
> > Does the patch below produce good results?
> >
> > diff --git a/lisp/cedet/pulse.el b/lisp/cedet/pulse.el
> > index 16243e1..8649254 100644
> > --- a/lisp/cedet/pulse.el
> > +++ b/lisp/cedet/pulse.el
> > @@ -161,6 +161,9 @@ pulse-reset-face
> > (face-background face nil t)
> > (face-background 'pulse-highlight-start-face)
> > ))
> > + (and face
> > + (set-face-extend 'pulse-highlight-face
> > + (face-extend-p face nil t)))
> > (put 'pulse-highlight-face :startface (or face
> > 'pulse-highlight-start-face))
> > (put 'pulse-highlight-face :iteration 0))
>
> Yes, it seems to behave as expected. Thanks.
Thanks, installed on the emacs-27 branch.
prev parent reply other threads:[~2020-04-09 16:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 13:06 Emacs 27 face :extend attribute not working with pulse.el? Adam Porter
2020-04-09 13:18 ` Adam Porter
2020-04-09 13:51 ` Eli Zaretskii
2020-04-09 14:46 ` Adam Porter
2020-04-09 16:46 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83blo0obdp.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=adam@alphapapa.net \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.