From: Eli Zaretskii <eliz@gnu.org>
To: Filipp Gunbin <fgunbin@fastmail.fm>
Cc: 41002@debbugs.gnu.org, egnartsms@gmail.com, larsi@gnus.org
Subject: bug#41002: Undo breaks inhibit-read-only text property
Date: Sat, 09 May 2020 10:37:52 +0300 [thread overview]
Message-ID: <83blmxh833.fsf@gnu.org> (raw)
In-Reply-To: <m2zhap8zyr.fsf@fastmail.fm> (message from Filipp Gunbin on Sun, 03 May 2020 06:22:20 +0300)
> From: Filipp Gunbin <fgunbin@fastmail.fm>
> Date: Sun, 03 May 2020 06:22:20 +0300
> Cc: 41002@debbugs.gnu.org, larsi@gnus.org
>
> --- a/src/textprop.c
> +++ b/src/textprop.c
> @@ -2301,0 +2301,4 @@
> + if (i->position + LENGTH (i) < end
> + && (!NILP (BVAR (current_buffer, read_only))
> + && NILP (Vinhibit_read_only)))
> + xsignal1 (Qbuffer_read_only, Fcurrent_buffer ());
>
> So if there happens to be an (writeable) interval ending before "end"
> (the end of the region we're killing with C-w), we will signal that the
> buffer is read-only. This may be read as "if we're going over the
> boundary of an interval, then check the _buffer_ read-onliness". Maybe
> Lars, as the author of this code, could comment on this.
I think you are right: we need to augment this with something that
pays attention to the inhibit-read-only property. Would you like to
suggest a patch?
Btw, how is this related to undo?
Thanks.
next prev parent reply other threads:[~2020-05-09 7:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 10:38 bug#41002: Undo breaks inhibit-read-only text property Serhii Mozghovyi
2020-05-02 17:33 ` Filipp Gunbin
2020-05-02 19:09 ` Serhii Mozghovyi
2020-05-03 3:22 ` Filipp Gunbin
2020-05-09 7:37 ` Eli Zaretskii [this message]
2020-05-09 13:34 ` Filipp Gunbin
2020-05-09 13:49 ` Eli Zaretskii
2020-05-09 16:55 ` Filipp Gunbin
2020-05-19 12:12 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83blmxh833.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=41002@debbugs.gnu.org \
--cc=egnartsms@gmail.com \
--cc=fgunbin@fastmail.fm \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.