From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#41520: 28.0.50; Crash in character.h due to assertion error Date: Sun, 27 Sep 2020 18:15:53 +0300 Message-ID: <83blhrntcm.fsf@gnu.org> References: <83imgkw11q.fsf@gnu.org> <837dx0vysk.fsf@gnu.org> <87wo0f1e3e.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7230"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41520@debbugs.gnu.org, stefan@marxist.se, pipcet@gmail.com To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 27 17:17:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kMYQI-0001jQ-BU for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 27 Sep 2020 17:17:10 +0200 Original-Received: from localhost ([::1]:43772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kMYQG-0007dO-OL for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 27 Sep 2020 11:17:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52426) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMYQA-0007d5-7S for bug-gnu-emacs@gnu.org; Sun, 27 Sep 2020 11:17:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38621) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kMYQ9-00027t-Tj for bug-gnu-emacs@gnu.org; Sun, 27 Sep 2020 11:17:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kMYQ9-0001pQ-NZ for bug-gnu-emacs@gnu.org; Sun, 27 Sep 2020 11:17:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Sep 2020 15:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41520 X-GNU-PR-Package: emacs Original-Received: via spool by 41520-submit@debbugs.gnu.org id=B41520.16012197764856 (code B ref 41520); Sun, 27 Sep 2020 15:17:01 +0000 Original-Received: (at 41520) by debbugs.gnu.org; 27 Sep 2020 15:16:16 +0000 Original-Received: from localhost ([127.0.0.1]:50166 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMYPP-0001Fu-Pj for submit@debbugs.gnu.org; Sun, 27 Sep 2020 11:16:16 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMYPO-0001B1-Ki for 41520@debbugs.gnu.org; Sun, 27 Sep 2020 11:16:15 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52218) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kMYPJ-00023D-1X; Sun, 27 Sep 2020 11:16:09 -0400 Original-Received: from [176.228.60.248] (port=2439 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kMYPI-000679-9y; Sun, 27 Sep 2020 11:16:08 -0400 In-Reply-To: <87wo0f1e3e.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 27 Sep 2020 16:36:21 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189139 Archived-At: > From: Lars Ingebrigtsen > Cc: Pip Cet , 41520@debbugs.gnu.org, stefan@marxist.se > Date: Sun, 27 Sep 2020 16:36:21 +0200 > > > I'm okay with those additional changes, but let's install them on > > master, as they are a cleanup, not a bug. > > Pip's patch from May no longer applies cleanly, so I've respun it for > the trunk now. > > Does this still look OK? Almost. I'd rather skip this part: > @@ -882,8 +881,7 @@ back_comment (ptrdiff_t from, ptrdiff_t from_byte, ptrdiff_t stop, > if (open_paren_in_column_0_is_defun_start > && NILP (Vcomment_use_syntax_ppss) > && (from == stop > - || (temp_byte = dec_bytepos (from_byte), > - FETCH_CHAR (temp_byte) == '\n'))) > + || (FETCH_BYTE (from_byte - 1) == '\n'))) It might be that I'm being paranoid here, but I don't like calling FETCH_BYTE when we are potentially in the middle of a multibyte sequence or near the gap. The rest should be fine, thanks.