From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.help Subject: Re: Set-window-vscroll sometimes doesn't work Date: Mon, 19 Oct 2020 19:24:13 +0300 Message-ID: <83blgyp4k2.fsf@gnu.org> References: <72B62847-3F35-412A-9F74-88442A936B19@gmail.com> <83eelvsivm.fsf@gnu.org> <853C8CD1-B58B-4F22-A889-4AB2AEE3DD80@gmail.com> <83imb7qw46.fsf@gnu.org> <66013ADF-731C-4922-8AF7-EAFDBF43C33C@gmail.com> <83ft6bqv0q.fsf@gnu.org> <4F2C1811-940E-4C58-8EE0-37AA3B666E12@gmail.com> <835z77qr3f.fsf@gnu.org> <834kmrq7gy.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16937"; mail-complaints-to="usenet@ciao.gmane.io" To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 19 18:24:55 2020 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kUXxv-0004Ik-L7 for geh-help-gnu-emacs@m.gmane-mx.org; Mon, 19 Oct 2020 18:24:55 +0200 Original-Received: from localhost ([::1]:55914 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUXxu-0003s1-Lj for geh-help-gnu-emacs@m.gmane-mx.org; Mon, 19 Oct 2020 12:24:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59636) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUXx8-0003pe-OA for help-gnu-emacs@gnu.org; Mon, 19 Oct 2020 12:24:06 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37257) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUXx8-0004KF-Fd for help-gnu-emacs@gnu.org; Mon, 19 Oct 2020 12:24:06 -0400 Original-Received: from [176.228.60.248] (port=3461 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kUXx7-0005W1-Oi for help-gnu-emacs@gnu.org; Mon, 19 Oct 2020 12:24:06 -0400 In-Reply-To: (message from Yuan Fu on Mon, 19 Oct 2020 00:59:33 -0400) X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:124582 Archived-At: > From: Yuan Fu > Date: Mon, 19 Oct 2020 00:59:33 -0400 > Cc: help-gnu-emacs@gnu.org > > >> Cool. I’m thinking about wrapping move_it_by_lines in window_scroll_pixel_based with a version that regards images (and tall lines) as several lines. Do you see some potential problems with that? > > > > What is the problem with the existing code that you are trying to > > solve? Whatever it is, it is highly likely that the solution already > > exists, and no new code is needed. > > The problem I have is that when I scroll over images they jumps in and out of the window: (bad-scrolling.mp4) AFAICT, you are trying to scroll an image that is smaller than the window? That's not supported by the current code, you will need to modify the criteria for entering the vscroll mode there. But in any case, I don't see how move_it_by_lines can have anything to do with this: whatever you do, an image must always remain a single "display element", and the only way we currently have to scroll partial images is via vscroll. Which works, so I don't understand why you need any changes in window_scroll_pixel_based.