From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master ac6b62b: * lisp/time.el (world-clock-mode): Make non-interactive. Date: Fri, 23 Apr 2021 14:25:37 +0300 Message-ID: <83bla5nsy6.fsf@gnu.org> References: <83sg3ho7ku.fsf@gnu.org> <83k0otnvc4.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22508"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 23 13:27:16 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lZtxr-0005dm-IG for ged-emacs-devel@m.gmane-mx.org; Fri, 23 Apr 2021 13:27:15 +0200 Original-Received: from localhost ([::1]:45912 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZtxq-0001YC-MB for ged-emacs-devel@m.gmane-mx.org; Fri, 23 Apr 2021 07:27:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37882) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZtwT-0000kI-OL for emacs-devel@gnu.org; Fri, 23 Apr 2021 07:25:49 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:46893) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZtwT-0002RL-CY; Fri, 23 Apr 2021 07:25:49 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4738 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lZtwP-0006Le-GS; Fri, 23 Apr 2021 07:25:47 -0400 In-Reply-To: (message from Stefan Kangas on Fri, 23 Apr 2021 10:58:24 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268315 Archived-At: > From: Stefan Kangas > Date: Fri, 23 Apr 2021 10:58:24 +0000 > Cc: emacs-devel@gnu.org > > Eli Zaretskii writes: > > >> This mode is only useful in a buffer prepared for its use by > >> `world-clock'. Running it in an arbitrary buffer will silently fail. > > > > Is that true also for turning off the mode? > > I don't think I understand the question: AFAIK, you can't turn off a > major mode (see `(elisp) Major Modes'). But you can of course still > switch to a different major mode with or without this change. Before your change, I could turn on this mode interactively in a buffer which was already formatted (e.g., by copy/paste from another such buffer, or in the original *wclock* buffer, if I switched to another major mode in it). With this change, doing that is no longer possible. So I think the least we need is to mention that in NEWS. IOW, it's a user-visible change, whether we think the previous functionality was useful or not.