From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#49963: 28.0.50; isearch failing in Dired after rectangle-mark-mode and query-replace Date: Tue, 10 Aug 2021 19:42:17 +0300 Message-ID: <83bl65fdzq.fsf@gnu.org> References: <87k0kudsb8.fsf@mail.linkov.net> <83r1f1fmi2.fsf@gnu.org> <83lf59fh7q.fsf@gnu.org> <87h7fxxq19.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13240"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 49963@debbugs.gnu.org, larsi@gnus.org, juri@linkov.net, laslydone@protonmail.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 10 18:43:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mDUqM-0003GH-Oj for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 10 Aug 2021 18:43:10 +0200 Original-Received: from localhost ([::1]:56504 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDUqL-0005pQ-Au for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 10 Aug 2021 12:43:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36614) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDUqE-0005p2-JE for bug-gnu-emacs@gnu.org; Tue, 10 Aug 2021 12:43:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49202) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mDUqE-0005Sq-C9 for bug-gnu-emacs@gnu.org; Tue, 10 Aug 2021 12:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mDUqE-0008QL-A4 for bug-gnu-emacs@gnu.org; Tue, 10 Aug 2021 12:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Aug 2021 16:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49963 X-GNU-PR-Package: emacs Original-Received: via spool by 49963-submit@debbugs.gnu.org id=B49963.162861374132275 (code B ref 49963); Tue, 10 Aug 2021 16:43:02 +0000 Original-Received: (at 49963) by debbugs.gnu.org; 10 Aug 2021 16:42:21 +0000 Original-Received: from localhost ([127.0.0.1]:60729 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDUpV-0008OP-1f for submit@debbugs.gnu.org; Tue, 10 Aug 2021 12:42:21 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDUpP-0008O5-Bd for 49963@debbugs.gnu.org; Tue, 10 Aug 2021 12:42:15 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57058) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDUpJ-0004Xz-9R; Tue, 10 Aug 2021 12:42:05 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4528 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDUpI-0006tz-SZ; Tue, 10 Aug 2021 12:42:05 -0400 In-Reply-To: (message from Stefan Monnier on Tue, 10 Aug 2021 11:56:58 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211533 Archived-At: > From: Stefan Monnier > Cc: Eli Zaretskii , 49963@debbugs.gnu.org, juri@linkov.net, > laslydone@protonmail.com > Date: Tue, 10 Aug 2021 11:56:58 -0400 > > Lars Ingebrigtsen [2021-08-10 17:44:50] wrote: > > Eli Zaretskii writes: > >> I meant can we please not use add-function and friends. Please? > > There isn't much difference between using add-function and add-hook most > > of the time (although here we trip over a `let' binding not doing what > > the author thought it did). > > FWIW, `add-hook` has the exact same problem with `let` (and we already > tripped against this exact same situation with `add-hook` and `let`). This is a misunderstanding of what bothers me. The problem is discoverability: add-function is not easily discoverable, if it is used on an internal function. IOW, the documentation of C-s doesn't tell you that its operation could be affected by that "hook". By contrast, if we use some other mechanism, like call a function via a variable or call a hook, and if we document these in the doc string of C-s, that problem will have disappeared, and finding causes of problems such as this one would be easier.