all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: carlosjosepita@gmail.com, 32210@debbugs.gnu.org
Subject: bug#32210: Support medium weighted fonts
Date: Thu, 21 Oct 2021 10:01:20 +0300	[thread overview]
Message-ID: <83bl3iamkf.fsf@gnu.org> (raw)
In-Reply-To: <875ytrksxe.fsf@gnus.org> (message from Lars Ingebrigtsen on Thu,  21 Oct 2021 04:33:49 +0200)

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: carlosjosepita@gmail.com,  32210@debbugs.gnu.org
> Date: Thu, 21 Oct 2021 04:33:49 +0200
> 
> I've now gone through all the fonts I have here that have different
> weights for medium and regular, and with the adjustments in the weights
> and Pango weights, I can now select both of them.  (And the other
> weights for Noto and DejaVu, which are the main fonts that I've tested
> with, also work.)
> 
> So I've pushed the changes now to the trunk.  If these changes don't
> work with other fonts, please let me know.

Hmm... bother:

>  static const struct table_entry weight_table[] =
>  {
>    { 0, { "thin" }},
> -  { 20, { "ultra-light", "ultralight" }},
> -  { 40, { "extra-light", "extralight" }},
> +  { 40, { "ultra-light", "ultralight", "extra-light", "extralight" }},

This loses the distinction between ultra-light and extra-light.  Are
these two really indistinguishable in all supported font backends?

>  static Lisp_Object
>  w32_to_fc_weight (int n)
>  {
> -  if (n >= FW_HEAVY)     return intern ("black");
> +  if (n >= FW_HEAVY)     return Qbold;
>    if (n >= FW_EXTRABOLD) return Qextra_bold;

This doesn't look right.  Should that Qbold be Qblack?





  reply	other threads:[~2021-10-21  7:01 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-19 14:06 bug#32210: Support medium weighted fonts Carlos Pita
2019-11-17  8:37 ` Lars Ingebrigtsen
2019-11-17 15:59   ` Eli Zaretskii
2019-11-17 17:06     ` Lars Ingebrigtsen
2019-11-17 17:54       ` Eli Zaretskii
2019-11-18 10:28         ` Lars Ingebrigtsen
2019-11-18 10:41           ` Lars Ingebrigtsen
2019-11-18 15:48             ` Eli Zaretskii
2019-11-18 17:17               ` Lars Ingebrigtsen
2019-11-18 17:26                 ` Eli Zaretskii
2019-11-19  8:23                   ` Lars Ingebrigtsen
2021-10-20 12:58                     ` Lars Ingebrigtsen
2021-10-20 13:11                       ` Eli Zaretskii
2021-10-20 13:20                         ` Lars Ingebrigtsen
2021-10-20 14:18                           ` Eli Zaretskii
2021-10-20 14:28                             ` Lars Ingebrigtsen
2021-10-20 14:42                               ` Lars Ingebrigtsen
2021-10-20 14:47                                 ` Lars Ingebrigtsen
2021-10-20 16:12                                 ` Eli Zaretskii
2021-10-21  2:33                                   ` Lars Ingebrigtsen
2021-10-21  7:01                                     ` Eli Zaretskii [this message]
2021-10-21 12:49                                       ` Lars Ingebrigtsen
2019-11-18 10:55           ` Robert Pluim
2019-11-18 17:32             ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83bl3iamkf.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=32210@debbugs.gnu.org \
    --cc=carlosjosepita@gmail.com \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.