From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 6ed1994d27: Prevent crashes from illegal locale coding systems Date: Wed, 16 Feb 2022 14:38:18 +0200 Message-ID: <83bkz72dhh.fsf@gnu.org> References: <83czjqrkew.fsf@gnu.org> <874k52kiu4.fsf@yahoo.com> <837d9yribj.fsf@gnu.org> <87v8xii83e.fsf@yahoo.com> <83r186p1h8.fsf@gnu.org> <878ruehx6n.fsf@yahoo.com> <83h791pmnl.fsf@gnu.org> <87iltheyeu.fsf@yahoo.com> <83wnhwol2o.fsf@gnu.org> <87tud0ybhj.fsf@yahoo.com> <837d9w450e.fsf@gnu.org> <87czjow7x1.fsf@yahoo.com> <8335kk440x.fsf@gnu.org> <87sfsjvdnm.fsf@yahoo.com> <87leybv8mp.fsf@yahoo.com> <87h78zv1hc.fsf@yahoo.com> <83fsoj2e7m.fsf@gnu.org> <87v8xfuh2z.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10802"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Feb 16 13:52:56 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nKJnk-0002iC-Br for ged-emacs-devel@m.gmane-mx.org; Wed, 16 Feb 2022 13:52:56 +0100 Original-Received: from localhost ([::1]:48428 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nKJni-00050I-LJ for ged-emacs-devel@m.gmane-mx.org; Wed, 16 Feb 2022 07:52:54 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34372) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nKJZe-0000rK-R0 for emacs-devel@gnu.org; Wed, 16 Feb 2022 07:38:23 -0500 Original-Received: from [2001:470:142:3::e] (port=50980 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nKJZb-0000wI-ES; Wed, 16 Feb 2022 07:38:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=h+/SDRvN12S8AFl/bXDdCZmYv0G+rYlrvRuiHJgYsEM=; b=JznRwihN/7iB hDhYB9eVAbJjcCzetu8wIIup5CoEWVvfrR8NmUmuScPIQn1etCvp0oIImtILa7Zjjqbx3X0x+8dty VBIOJBt1j22wvHK1FaCF4ONfXnNlSBfTQpYoyOH0t/zdvbrO29nDc2IO2buJ0f0Er4my5sZdZ7KK2 /8BJtccuBUr1I/4LJv3lsvsJS6R7OSdJ2Av+LQhcNQSWxr2i/9IqeGt5p0m8lGO9WlU1JA1t+LjoB 0ZmmvTNKP1OZ6F+fQB0LVtEQKilku2VEhAFZYbMaq0KtIiFcLrU2kbcfeOQL5ncVxwVynqlyXlWJ4 PE9w23zPqEpj+dl2K0aLaw==; Original-Received: from [87.69.77.57] (port=4271 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nKJZV-0006N4-Fy; Wed, 16 Feb 2022 07:38:17 -0500 In-Reply-To: <87v8xfuh2z.fsf@yahoo.com> (message from Po Lu on Wed, 16 Feb 2022 20:33:08 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286380 Archived-At: > From: Po Lu > Cc: emacs-devel@gnu.org > Date: Wed, 16 Feb 2022 20:33:08 +0800 > > Eli Zaretskii writes: > > > Only if this is a recent problem. Otherwise, I'd prefer not to > > introduce such non-trivial code into the release branch so late into > > the pretest. > > It's a problem that cropped up in GLib after 27.1 was released, but I > don't know if that counts as recent enough. Emacs 27.1 was release 1.5 years ago. If these problems are real, we should have heard about them by now. > Perhaps we could install the simpler fix that avoids passing an invalid > coding system to setup_coding_system on the release branch, which should > cover botched values of `locale-coding-system'. That's too general a fix in a place that's too low-level to know what is TRT in these cases. It would prevent us from signaling an error when a Lisp program uses an invalid encoding, for example -- these problems cannot be silently ignored.