From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master b2e6e95581: Only reset buffer-local buffer-stale-function in make-indirect-buffer Date: Mon, 11 Jul 2022 20:20:31 +0300 Message-ID: <83bktvzhuo.fsf@gnu.org> References: <165754851290.3031.9159264035427641051@vcs2.savannah.gnu.org> <20220711140833.3343AC0D772@vcs2.savannah.gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32603"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, larsi@gnus.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jul 11 19:24:07 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oAx8g-0008MF-Sk for ged-emacs-devel@m.gmane-mx.org; Mon, 11 Jul 2022 19:24:07 +0200 Original-Received: from localhost ([::1]:51380 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oAx8f-0006q1-6o for ged-emacs-devel@m.gmane-mx.org; Mon, 11 Jul 2022 13:24:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46604) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oAx5S-0004Mj-1h for emacs-devel@gnu.org; Mon, 11 Jul 2022 13:20:51 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56738) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oAx5Q-0002Ko-Da; Mon, 11 Jul 2022 13:20:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=use4Ia5nXG809cGDPti9MYwTLmwHJ7DFRJosaVmJjVM=; b=MiWy4EohHsWH FfpD2jBOhiC/8U/a2hpbXdvIyVFkw1UfXQbOdJzhfNJP/zR9bWu1KM0vy5u2KZlG+Om07en/DTveT vmtbTTB24vdRgEqeIlOlApJGzvLfGAqmIg3yx1sqx4t6CCAvuRehdbXcdOG6xg/C5OGL1egndmr1x 85xyxhgqDgtXRpXp7OzoO4+cMIFYbrPzqAbCPMjEn2LoqRPf5oVqypZhV7cXjaaWuCKPusVCouCpU MPUovnLtMUH2dR74w7zV06ZFtmcHrvfuQGzKi6BMLRHIlTaTmCBQavBoTKyOF2cfV3aPUYXpveJae XjAND4jbg5nPBPnsXO8GZg==; Original-Received: from [87.69.77.57] (port=1216 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oAx5P-0006jG-OI; Mon, 11 Jul 2022 13:20:44 -0400 In-Reply-To: (message from Stefan Monnier on Mon, 11 Jul 2022 11:59:20 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292060 Archived-At: > From: Stefan Monnier > Cc: Lars Ingebrigtsen > Date: Mon, 11 Jul 2022 11:59:20 -0400 > > > + if (!NILP (Flocal_variable_p (Qbuffer_stale_function, base_buffer))) > > + Fset (Qbuffer_stale_function, Qbuffer_stale__default_function); > > Shouldn't this use `kill-local-variable` instead or something like that? I'm also not sure it is wise not to use nil here, since buffer-stale--default-function is only defined when files.el is loaded, so this could cause trouble during bootstrap (if not now, then in some distant future). At least Ffboundp test is in order, I think.