From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56561: 29.0.50; Infloop in try_window Date: Fri, 15 Jul 2022 18:56:51 +0300 Message-ID: <83bktqs724.fsf@gnu.org> References: <874jzjwmhn.fsf@md5i.com> <83v8rzsdd1.fsf@gnu.org> <878rovxqjo.fsf@md5i.com> <83sfn2sy19.fsf@gnu.org> <83lesusl4w.fsf@gnu.org> <87lesumqgf.fsf@yahoo.com> <83ilnysbc5.fsf@gnu.org> <83fsj2s8fg.fsf@gnu.org> <83cze6s7xt.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20527"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mwd@md5i.com, 56561@debbugs.gnu.org To: luangruo@yahoo.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 15 17:58:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oCNhj-000506-PZ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Jul 2022 17:58:11 +0200 Original-Received: from localhost ([::1]:53956 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oCNhi-0005Mf-99 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Jul 2022 11:58:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56258) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCNha-0005LE-Ap for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2022 11:58:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44288) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oCNha-0004el-2O for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2022 11:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oCNhZ-0005Wx-OS for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2022 11:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Jul 2022 15:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56561 X-GNU-PR-Package: emacs Original-Received: via spool by 56561-submit@debbugs.gnu.org id=B56561.165790062421184 (code B ref 56561); Fri, 15 Jul 2022 15:58:01 +0000 Original-Received: (at 56561) by debbugs.gnu.org; 15 Jul 2022 15:57:04 +0000 Original-Received: from localhost ([127.0.0.1]:42047 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCNge-0005Vc-2F for submit@debbugs.gnu.org; Fri, 15 Jul 2022 11:57:04 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43212) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCNga-0005V6-5P for 56561@debbugs.gnu.org; Fri, 15 Jul 2022 11:57:02 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35188) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCNgU-0004Gi-Ho; Fri, 15 Jul 2022 11:56:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=t5KLoMNqHSH6Fhxnk+mVMmnFgMipCGn7qUNlTWWBxZk=; b=GZFs3t2HwmqV KMdiLtD1ROgQjWGYsYj6mXsTUjWsi189QyY5dLogPsT5xpfgE0ycREUrNw4uGZkfIGOJqmNk2I8t+ 8ZhD+V810YDvQwW0BKEQF65uDZ/Viai84Q04hsd+Orj7jl6b2EodIOxq1v3dR3eL0ujSTTXzg+nVY JAlim4i5IY34yLdGnjRpBAEavN+zmoC2CveQhbxM7zU1R7+/mtpYTKYTLlFkYWIioiBhUhTdstHB/ PEGgGtNmFPHhInY54IqkG2NYcW0vYImyqfKg/XHp7tJnWaerupI70mvndFAxJGVYT4Ul/YpIWry9w rzYbqY8Ev0gCvlYd1+IrMQ==; Original-Received: from [87.69.77.57] (port=1298 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCNgU-0006b0-1V; Fri, 15 Jul 2022 11:56:54 -0400 In-Reply-To: <83cze6s7xt.fsf@gnu.org> (message from Eli Zaretskii on Fri, 15 Jul 2022 18:37:50 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237118 Archived-At: > Cc: mwd@md5i.com, 56561@debbugs.gnu.org > Date: Fri, 15 Jul 2022 18:37:50 +0300 > From: Eli Zaretskii > > On third thought, why do we even call try_window there? The original > code needed try_window because it then used the glyph matrix it > produces to calculate the size of the tooltip. But we've dumped that > code, and we nowadays use window-text-pixel-size instead, which > emulates the display internally anyway. So I think we should simply > delete the call to try_window from x-show-tip, and be done. At least > on master. No, that's wrong: we call update_single_window there, and that requires a window with a desired matrix set up correctly. So yes, the call to try_window is still needed.