bug#57241: Commit b87400c broke master

bug#57241: Commit b87400c broke master

[Dario Gjorgjevski]

(I am using Gmail's webmail; here's hoping its Plain text mode works.)

Running `make bootstrap' results in:

In toplevel form:
xwidget.el:33:2: Error: Symbol’s function definition is void:
fringe-custom-set-bitmap
make[4]: *** [xwidget.elc] Error 1

I suspect a `require' or an autoload cookie is missing.  Adding
`(require 'fringe)' to lisp/bookmark.el works, but is probably not the
best solution.

Best regards,
Dario

bug#57241: Commit b87400c broke master

[Eli Zaretskii]

> Cc: Jim Porter <jporterbugs@gmail.com>
> From: Dario Gjorgjevski <dario.gjorgjevski@gmail.com>
> Date: Tue, 16 Aug 2022 14:39:04 +0200
> 
> (I am using Gmail's webmail; here's hoping its Plain text mode works.)
> 
> Running `make bootstrap' results in:
> 
> In toplevel form:
> xwidget.el:33:2: Error: Symbol’s function definition is void:
> fringe-custom-set-bitmap
> make[4]: *** [xwidget.elc] Error 1

Please show all the information about your build.
fringe-custom-set-bitmap is in fringe.el, which is preloaded in the X
build.  Are you building --without-x or something?

bug#57241: Commit b87400c broke master

[Dario Gjorgjevski]

On Tue, Aug 16, 2022 at 2:55 PM Eli Zaretskii <eliz@gnu.org> wrote:
>
> Please show all the information about your build.
> fringe-custom-set-bitmap is in fringe.el, which is preloaded in the X
> build.  Are you building --without-x or something?

Yes, I am building --without-x --with-json --with-native-compilation.
Also --prefix=$HOME/.local/opt/emacs.  All passed via `make bootstrap
configure="..."'.

Best regards,
Dario

bug#57241: Commit b87400c broke master

[Eli Zaretskii]

> From: Dario Gjorgjevski <dario.gjorgjevski@gmail.com>
> Date: Tue, 16 Aug 2022 15:07:29 +0200
> Cc: 57241@debbugs.gnu.org, jporterbugs@gmail.com
> 
> On Tue, Aug 16, 2022 at 2:55 PM Eli Zaretskii <eliz@gnu.org> wrote:
> >
> > Please show all the information about your build.
> > fringe-custom-set-bitmap is in fringe.el, which is preloaded in the X
> > build.  Are you building --without-x or something?
> 
> Yes, I am building --without-x --with-json --with-native-compilation.
> Also --prefix=$HOME/.local/opt/emacs.  All passed via `make bootstrap
> configure="..."'.

Can you (load "fringe") in such a build?  If not, a simple 'require'
won't help.

bug#57241: Commit b87400c broke master

[Dario Gjorgjevski]

On Tue, Aug 16, 2022 at 3:17 PM Eli Zaretskii <eliz@gnu.org> wrote:>
> Can you (load "fringe") in such a build?  If not, a simple 'require'
> won't help.

Yes, I can.

bug#57241: Commit b87400c broke master

[Eli Zaretskii]

> From: Dario Gjorgjevski <dario.gjorgjevski@gmail.com>
> Date: Tue, 16 Aug 2022 15:23:58 +0200
> Cc: 57241@debbugs.gnu.org, jporterbugs@gmail.com
> 
> On Tue, Aug 16, 2022 at 3:17 PM Eli Zaretskii <eliz@gnu.org> wrote:>
> > Can you (load "fringe") in such a build?  If not, a simple 'require'
> > won't help.
> 
> Yes, I can.

OK, I tried to fix this now.

Jim, I wonder whether the default value should be nil on TTY frames.

bug#57241: Commit b87400c broke master

[Jim Porter]

On 8/16/2022 6:42 AM, Eli Zaretskii wrote:
>> From: Dario Gjorgjevski <dario.gjorgjevski@gmail.com>
>> Date: Tue, 16 Aug 2022 15:23:58 +0200
>> Cc: 57241@debbugs.gnu.org, jporterbugs@gmail.com
>>
>> On Tue, Aug 16, 2022 at 3:17 PM Eli Zaretskii <eliz@gnu.org> wrote:>
>>> Can you (load "fringe") in such a build?  If not, a simple 'require'
>>> won't help.
>>
>> Yes, I can.
> 
> OK, I tried to fix this now.

Maybe it would make sense for fringe.el to be loaded in all builds, but 
to have more things be stub implementations like 'define-fringe-bitmap' 
is? Or maybe 'fringe-custom-set-bitmap' should just be autoloaded?

'require' works here, but if other places start using 
'fringe-custom-set-bitmap' they'll break --without-x builds too. For 
example, gdb-mi.el and edebug.el seem like good candidates for 
eventually doing something like bookmark.el does.

> Jim, I wonder whether the default value should be nil on TTY frames.

It could make sense on --without-x builds, but I don't think it should 
depend on the frame type. With the Emacs daemon, you might switch 
between TTY and GUI frames, and it would be strange if you didn't see 
the fringe indicator in a GUI frame if you had set the indicator in a 
TTY frame.

That said, on --without-x builds, setting a fringe indicator on a 
particular line of text should be safe, right? It just doesn't display 
anything, I think. Previously, I believe the code would (try to) set the 
fringe indicator on --without-x builds, and it seems to not be a 
problem, or else someone would have filed a bug about that against Emacs 28.

bug#57241: Commit b87400c broke master

[Mattias Engdegård]

Looks like test-custom-opts are still broken with respect to bookmark-fringe-mark, at least on EMBA.

bug#57241: Commit b87400c broke master

[Mattias Engdegård]

reopen 57241
stop

For the test-custom-opts failure.

bug#57241: Commit b87400c broke master

[Jim Porter]

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

On 8/30/2022 7:55 AM, Mattias Engdegård wrote:
> reopen 57241
> stop
> 
> For the test-custom-opts failure.

The attached patch fixes this for me. Does this seem like a reasonable 
way to go about it?

[-- Attachment #2: 0001-Under-no-X-builds-allow-any-value-for-fringe-bitmap-.patch --]
[-- Type: text/plain, Size: 1148 bytes --]

From 86152743c478c7aca95ce9de9edfd78d29718faa Mon Sep 17 00:00:00 2001
From: Jim Porter <jporterbugs@gmail.com>
Date: Wed, 31 Aug 2022 22:52:34 -0700
Subject: [PATCH] Under no-X builds, allow any value for 'fringe-bitmap'
 options

* lisp/cus-edit (fringe-bitmap): Always match under no-X.
---
 lisp/cus-edit.el | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el
index d3768766be..2229b6bdb7 100644
--- a/lisp/cus-edit.el
+++ b/lisp/cus-edit.el
@@ -4298,7 +4298,12 @@ 'fringe-bitmap
   "A Lisp fringe bitmap name."
   :format "%v"
   :tag "Fringe bitmap"
-  :match (lambda (_widget value) (fringe-bitmap-p value))
+  :match (lambda (_widget value)
+           ;; In no-X builds, allow anything.  This ensures that
+           ;; customizations set on a with-X build aren't considered
+           ;; invalid under no-X.
+           (or (not (boundp 'fringe-bitmaps))
+               (fringe-bitmap-p value)))
   :completions (apply-partially #'completion-table-with-predicate
                                 obarray #'fringe-bitmap-p 'strict)
   :prompt-match 'fringe-bitmap-p
-- 
2.25.1

bug#57241: Commit b87400c broke master

[Mattias Engdegård]

1 sep. 2022 kl. 07.55 skrev Jim Porter <jporterbugs@gmail.com>:

> The attached patch fixes this for me. Does this seem like a reasonable way to go about it?

Looks reasonable. Let's give it a try!

bug#57241: Commit b87400c broke master

[Jim Porter]

On 9/1/2022 1:04 AM, Mattias Engdegård wrote:
> 1 sep. 2022 kl. 07.55 skrev Jim Porter <jporterbugs@gmail.com>:
> 
>> The attached patch fixes this for me. Does this seem like a reasonable way to go about it?
> 
> Looks reasonable. Let's give it a try!

Ok, merged as 4db596d316263a12bacf1632092a04032a8cde1c.

bug#57241: Commit b87400c broke master

[Mattias Engdegård]

> Ok, merged as 4db596d316263a12bacf1632092a04032a8cde1c.

Thank you, and it seems that emba.gnu.org is happy now (in this respect) so I'm marking the bug as done.