From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58334: 29.0.50; ASAN heap use after free in gui_produce_glyphs Date: Fri, 07 Oct 2022 15:05:41 +0300 Message-ID: <83bkqnon3e.fsf@gnu.org> References: <87mta8qx48.fsf@yahoo.com> <83v8ownmi1.fsf@gnu.org> <83r0zjopre.fsf@gnu.org> <83h70foo3h.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32844"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, 58334@debbugs.gnu.org To: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 07 16:13:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ogo6G-0008O1-7m for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Oct 2022 16:13:16 +0200 Original-Received: from localhost ([::1]:39096 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ogo6F-0000VG-5o for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Oct 2022 10:13:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35202) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogm79-0001Dq-79 for bug-gnu-emacs@gnu.org; Fri, 07 Oct 2022 08:06:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35527) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ogm78-0007bH-Rd for bug-gnu-emacs@gnu.org; Fri, 07 Oct 2022 08:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ogm78-000431-Lt for bug-gnu-emacs@gnu.org; Fri, 07 Oct 2022 08:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Oct 2022 12:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58334 X-GNU-PR-Package: emacs Original-Received: via spool by 58334-submit@debbugs.gnu.org id=B58334.166514435015535 (code B ref 58334); Fri, 07 Oct 2022 12:06:02 +0000 Original-Received: (at 58334) by debbugs.gnu.org; 7 Oct 2022 12:05:50 +0000 Original-Received: from localhost ([127.0.0.1]:34604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ogm6w-00042U-3R for submit@debbugs.gnu.org; Fri, 07 Oct 2022 08:05:50 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33312) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ogm6u-00042H-ES for 58334@debbugs.gnu.org; Fri, 07 Oct 2022 08:05:48 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40592) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogm6p-0007ZZ-7S; Fri, 07 Oct 2022 08:05:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=SWAPVHnf7IAVw+B/261Mb2EJQTzz55RCZHWMiQ711MQ=; b=aVI1qRgQqB6iCwxR7tXq hpx4xPHM5uhGrqpV8YvMAY8ZuICnTWqt4Hlli690iLlrQCkTgCm04TnGzMntdN3np3v05CCwKQyYg 6TrOg7jp0BqLEfT7i9vPsqq/01tF1yeWHrPtBXIus0NznQ8ESFmpOF2a+zMqEgpcyD6PY/74Js+Ea RFQ0HQqXQi8ZAcKtPEwg1cLi3koZOSFO20rYvc98CizkmdHVvirD4jKo/ejIjVHIXsu5DNlcHVF92 zKKbpYX9Yajv1DHY3y5lJb4oJTSm89qV1hK84kbg6gLqSE3Ls+PXDhgDi+kE92f7//Cc5tkMzLf36 6bokjACpNkSE+g==; Original-Received: from [87.69.77.57] (port=3818 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogm6o-0003ga-LW; Fri, 07 Oct 2022 08:05:43 -0400 In-Reply-To: (message from Gerd =?UTF-8?Q?M=C3=B6llmann?= on Fri, 07 Oct 2022 14:01:49 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244776 Archived-At: > From: Gerd Möllmann > Cc: luangruo@yahoo.com, 58334@debbugs.gnu.org > Date: Fri, 07 Oct 2022 14:01:49 +0200 > > Eli Zaretskii writes: > > > So I would recommend to fix FACE_FROM_ID to re-generate the basic > > faces if needed, on the assumption that the cases where we have > > problems with using face ID are limited to basic faces. If, after > > that, we will find cases with non-basic faces, I'd first look for more > > opportunities to use inhibit_free_realized_faces. > > Sigh, I'd rather do something easy I'm not sure there are any "easy" solutions to this. We could keep sprinkling inhibit_free_realized_faces some more (over the last years, I added quite a few of them, and in other cases added calls to realize_basic_faces). > BTW, I've commented out the call to redisplay in nsterm.m > layoutSomething now in my branch. Let's see what the effect is. So far > I don't notice anything. If Git history for the code which calls redisplay shows commits that have references to bug reports in their log messages, perhaps read those bug reports to see if they show recipes for problems that were supposed to be fixed by adding that call.