From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58363: [PATCH 3/3] Improve error data signaled by sqlite-execute et al. Date: Sat, 22 Oct 2022 09:49:17 +0300 Message-ID: <83bkq4uzde.fsf@gnu.org> References: <87v8orky2u.fsf@gnus.org> <20221021210636.13329-1-jonas@bernoul.li> <20221021210636.13329-4-jonas@bernoul.li> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35270"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58363@debbugs.gnu.org To: Jonas Bernoulli Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 22 09:11:35 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1om8fO-00092N-SS for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Oct 2022 09:11:34 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1om8Kc-0002KK-Sz; Sat, 22 Oct 2022 02:50:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1om8KY-0002Jz-3r for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2022 02:50:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1om8KX-0008Et-Rr for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2022 02:50:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1om8KX-0000hE-Nh for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2022 02:50:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Oct 2022 06:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58363 X-GNU-PR-Package: emacs Original-Received: via spool by 58363-submit@debbugs.gnu.org id=B58363.16664213762639 (code B ref 58363); Sat, 22 Oct 2022 06:50:01 +0000 Original-Received: (at 58363) by debbugs.gnu.org; 22 Oct 2022 06:49:36 +0000 Original-Received: from localhost ([127.0.0.1]:39587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1om8K8-0000gU-0R for submit@debbugs.gnu.org; Sat, 22 Oct 2022 02:49:36 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1om8Ju-0000g4-4a for 58363@debbugs.gnu.org; Sat, 22 Oct 2022 02:49:34 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1om8Jo-0008BJ-Uu; Sat, 22 Oct 2022 02:49:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=vHjOxnsyOORxi3KK87ZncYeRGs0lCH6ZV1nknnCGWE4=; b=Wqh2+L8jbpRD FHyZ1Jb3AveytQo4KLTrqjalUXtKw83A+DhHq6jNikbBqaBTvnDt7owq4F11Shom2qDLfYW5Wt68a DKvWf3TkjVTZFT5KEa4sgGdc6F0ml/527eWTWNHJ3nJ8VthjIX6iZfTDkVdbMSj5osO7AF7MldA2q z6eHf8qpBfbvBRX1HJ7d3KGtlZlHiVV3gdmTeAqmgtfK77IuqiJXIbkU8kwTf1sHzQPrRI3zBvDAg EhXFWnikE43aSGJoLnBViimaPtgNmnPNhApE8riTrxUeY+18I4ErAEBN52iMtybJziXVfm7SSDGqH jDyYUrLUO/VYnbOeujI0Ag==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1om8Jo-0007YE-6N; Sat, 22 Oct 2022 02:49:16 -0400 In-Reply-To: <20221021210636.13329-4-jonas@bernoul.li> (message from Jonas Bernoulli on Fri, 21 Oct 2022 23:06:36 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246026 Archived-At: > From: Jonas Bernoulli > Date: Fri, 21 Oct 2022 23:06:36 +0200 > > + Lisp_Object ext_errcode = make_fixnum (sqlite3_extended_errcode (sdb)); > + const char *errmsg = sqlite3_errmsg (sdb); > + return list4 (errstr, errmsg ? build_string (errmsg) : Qnil, > + errcode, ext_errcode); ^^^^ Is that Qnil really a good idea here? What will an error message look like in that case? We may wish replacing Qnil with some standard text, if it looks better.